From: Jason Merrill <jason@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Richard Henderson <rth@redhat.com>,
Cary Coutant <ccoutant@google.com>,
gcc-patches@gcc.gnu.org,
Roland McGrath <roland@hack.frob.com>,
Jan Kratochvil <jkratoch@redhat.com>,
Tom Tromey <tromey@redhat.com>,
Mark Wielaard <mjw@redhat.com>
Subject: Re: [PATCH] Typed DWARF stack
Date: Fri, 29 Apr 2011 21:01:00 -0000 [thread overview]
Message-ID: <4DBB25D5.3060605@redhat.com> (raw)
In-Reply-To: <20110416081117.GV17079@tyan-ft48-01.lab.bos.redhat.com>
On 04/16/2011 04:11 AM, Jakub Jelinek wrote:
> + case dw_val_class_const_double:
> + {
> + unsigned HOST_WIDE_INT first, second;
> + l = 2 * HOST_BITS_PER_WIDE_INT / HOST_BITS_PER_CHAR;
> +
> + dw2_asm_output_data (1, l, NULL);
> + if (WORDS_BIG_ENDIAN)
> + {
> + first = val2->v.val_double.high;
> + second = val2->v.val_double.low;
> + }
> + else
> + {
> + first = val2->v.val_double.low;
> + second = val2->v.val_double.high;
> + }
> + dw2_asm_output_data (HOST_BITS_PER_WIDE_INT / HOST_BITS_PER_CHAR,
> + first, NULL);
> + dw2_asm_output_data (HOST_BITS_PER_WIDE_INT / HOST_BITS_PER_CHAR,
> + second, NULL);
> + }
How about moving the 2* into the first call to dw2_asm_output_data so
that the later calls can just use 'l'?
> + unsigned r = val1->v.val_unsigned;
> + unsigned long o = get_base_type_offset (val2->v.val_die_ref.die);
> + if (for_eh_or_skip>= 0)
> + r = DWARF2_FRAME_REG_OUT (r, for_eh_or_skip);
> + gcc_assert (size_of_uleb128 (r)
> + == size_of_uleb128 (val1->v.val_unsigned)&& o);
Maybe move this assert inside the if?
> + /* Sort by increasing usage count, as when readding the last
"reading"
OK with these changes.
Jason
next prev parent reply other threads:[~2011-04-29 20:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-25 11:33 [RFC PATCH] " Jakub Jelinek
2011-03-25 16:48 ` Roland McGrath
2011-03-28 9:25 ` Jakub Jelinek
2011-03-25 17:51 ` Cary Coutant
2011-04-16 9:28 ` [PATCH] " Jakub Jelinek
2011-04-29 21:01 ` Jason Merrill [this message]
2011-05-03 13:34 ` H.J. Lu
2011-05-08 18:57 ` H.J. Lu
2011-05-04 18:22 ` [RFC PATCH] " Tom Tromey
2011-05-04 18:30 ` Cary Coutant
2011-05-04 18:37 ` Jakub Jelinek
2011-05-04 20:27 ` Tom Tromey
2011-05-12 21:16 ` Tom Tromey
2011-05-12 21:37 ` Tom Tromey
2011-06-09 15:47 ` Typed DWARF stack and convert to untyped Jakub Jelinek
2011-06-09 18:34 ` Jakub Jelinek
2011-06-13 15:34 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DBB25D5.3060605@redhat.com \
--to=jason@redhat.com \
--cc=ccoutant@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jkratoch@redhat.com \
--cc=mjw@redhat.com \
--cc=roland@hack.frob.com \
--cc=rth@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).