From: "H.J. Lu" <hjl.tools@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Richard Henderson <rth@redhat.com>,
Jason Merrill <jason@redhat.com>,
Cary Coutant <ccoutant@google.com>,
gcc-patches@gcc.gnu.org, Roland McGrath <roland@hack.frob.com>,
Jan Kratochvil <jkratoch@redhat.com>,
Tom Tromey <tromey@redhat.com>, Mark Wielaard <mjw@redhat.com>
Subject: Re: [PATCH] Typed DWARF stack
Date: Sun, 08 May 2011 18:57:00 -0000 [thread overview]
Message-ID: <BANLkTimvXoZUwen2p3NR6TcqKWwkkOoeNA@mail.gmail.com> (raw)
In-Reply-To: <BANLkTik=tQ=YoJpcw2w6nFJCg3VAcvCqkQ@mail.gmail.com>
On Tue, May 3, 2011 at 6:33 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Sat, Apr 16, 2011 at 1:11 AM, Jakub Jelinek <jakub@redhat.com> wrote:
>> On Fri, Mar 25, 2011 at 12:32:37PM +0100, Jakub Jelinek wrote:
>>> As I said in my GCC Summit talk, currently we just give up on
>>> any floating point/_Decimal*/__int128 and for 32-bit targets even
>>> long long expressions, as those can't be represented in DWARF4,
>>> while var-tracking has all that often available.
>>
>> ...
>>
>> This is an updated patch for the typed DWARF stack support,
>> against current trunk. I've changed DW_OP_GNU_reinterpret
>> from 0xf8 to 0xf9, because 0xf8 is taken by PGI and e.g. binutils prefers no
>> clashes between extension opcodes, otherwise readers would need to switch
>> based on producer. When we are close to running out of extension opcodes,
>> we may reconsider (especially as the HP block is quite large).
>>
>> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
>>
>> 2011-04-16 Jakub Jelinek <jakub@redhat.com>
>>
>> * dwarf2.h (DW_OP_GNU_const_type, DW_OP_GNU_regval_type,
>> DW_OP_GNU_deref_type, DW_OP_GNU_convert, DW_OP_GNU_reinterpret): New.
>>
>> * dwarf2out.c (get_address_mode): New inline.
>> (mem_loc_descriptor): Add MEM_MODE parameter, adjust recursive calls,
>> if not dwarf_strict emit
>> DW_OP_GNU_{{const,regval,deref}_type,convert,reinterpret} when
>> desirable. Handle FLOAT_EXTEND, FLOAT_TRUNCATE, FLOAT,
>> UNSIGNED_FLOAT, FIX and UNSIGNED_FIX. Just return NULL for
>> FMA, STRICT_LOW_PART, CONST_VECTOR and CONST_FIXED.
>> (dwarf2out_frame_debug_cfa_expression, reg_loc_descriptor,
>> dw_loc_list_1, cst_pool_loc_descr, loc_list_from_tree): Adjust
>> mem_loc_descriptor callers.
>> (dwarf_stack_op_name, size_of_loc_descr, output_loc_operands,
>> output_loc_operands_raw, hash_loc_operands, compare_loc_operands):
>> Handle DW_OP_GNU_const_type, DW_OP_GNU_regval_type,
>> DW_OP_GNU_deref_type, DW_OP_GNU_convert and DW_OP_GNU_reinterpret.
>> (base_types): New variable.
>> (get_base_type_offset, calc_base_type_die_sizes,
>> base_type_for_mode, mark_base_types, base_type_cmp,
>> move_marked_base_types): New functions.
>> (calc_die_sizes): Assert that die_offset is 0 or equal to
>> next_die_offset.
>> (loc_descriptor): Only handle here lowpart SUBREGs of REG, for
>> others defer to mem_loc_descriptor. Adjust mem_loc_descriptor
>> callers. If not dwarf_strict, call mem_loc_descriptor even for
>> non-MODE_INT modes or MODE_INT modes larger than DWARF2_ADDR_SIZE.
>> (gen_subprogram_die): Don't give up on call site parameters
>> with non-integral or large integral modes. Adjust
>> mem_loc_descriptor callers.
>> (prune_unused_types): Call prune_unused_types_mark on base_types
>> vector entries.
>> (resolve_addr): Call mark_base_types.
>> (dwarf2out_finish): Call move_marked_base_types.
>
> This caused:
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48853
>
This also caused:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48928
--
H.J.
next prev parent reply other threads:[~2011-05-08 13:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-25 11:33 [RFC PATCH] " Jakub Jelinek
2011-03-25 16:48 ` Roland McGrath
2011-03-28 9:25 ` Jakub Jelinek
2011-03-25 17:51 ` Cary Coutant
2011-04-16 9:28 ` [PATCH] " Jakub Jelinek
2011-04-29 21:01 ` Jason Merrill
2011-05-03 13:34 ` H.J. Lu
2011-05-08 18:57 ` H.J. Lu [this message]
2011-05-04 18:22 ` [RFC PATCH] " Tom Tromey
2011-05-04 18:30 ` Cary Coutant
2011-05-04 18:37 ` Jakub Jelinek
2011-05-04 20:27 ` Tom Tromey
2011-05-12 21:16 ` Tom Tromey
2011-05-12 21:37 ` Tom Tromey
2011-06-09 15:47 ` Typed DWARF stack and convert to untyped Jakub Jelinek
2011-06-09 18:34 ` Jakub Jelinek
2011-06-13 15:34 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimvXoZUwen2p3NR6TcqKWwkkOoeNA@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=ccoutant@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jason@redhat.com \
--cc=jkratoch@redhat.com \
--cc=mjw@redhat.com \
--cc=roland@hack.frob.com \
--cc=rth@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).