From: Vladimir Makarov <vmakarov@redhat.com>
To: Hans-Peter Nilsson <hp@bitrange.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: FORBIDDEN_INC_DEC_CLASSES in ira-costs.c
Date: Thu, 09 Jun 2011 16:24:00 -0000 [thread overview]
Message-ID: <4DF0EF39.5020409@redhat.com> (raw)
In-Reply-To: <alpine.BSF.2.00.1106081231490.80906@dair.pair.com>
On 06/08/2011 12:37 PM, Hans-Peter Nilsson wrote:
> There's a lot of dead code inside the obsolete (removed in 2009)
> and nowhere else set #ifdef FORBIDDEN_INC_DEC_CLASSES.
> Remove and poison?
>
Yes, I believe so.
> I'd say borderline obvious, but maybe there's instead reason to
> reinstate it, if that code is tested and supposed to be live.
I can not remember a reason to save it. A big part of ira-costs.c was
inherited from old reglcasses.c before the macro was removed. Probably
therefore it occurred again.
Thanks for finding this. I'd really appreciate if you submit a patch
removing this. I'll try to give it a quick review.
next prev parent reply other threads:[~2011-06-09 16:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 16:49 Hans-Peter Nilsson
2011-06-09 16:24 ` Vladimir Makarov [this message]
2011-06-10 3:46 ` Hans-Peter Nilsson
2011-06-10 13:08 ` Hans-Peter Nilsson
2011-06-10 14:03 ` Vladimir Makarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF0EF39.5020409@redhat.com \
--to=vmakarov@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hp@bitrange.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).