From: Hans-Peter Nilsson <hp@bitrange.com>
To: Vladimir Makarov <vmakarov@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: FORBIDDEN_INC_DEC_CLASSES in ira-costs.c
Date: Fri, 10 Jun 2011 13:08:00 -0000 [thread overview]
Message-ID: <alpine.BSF.2.00.1106100827100.52008@dair.pair.com> (raw)
In-Reply-To: <alpine.BSF.2.00.1106092254551.61896@dair.pair.com>
On Thu, 9 Jun 2011, Hans-Peter Nilsson wrote:
> * ira-costs.c: Remove #ifdefs on dead FORBIDDEN_INC_DEC_CLASSES.
> Adjust comments.
> * system.h (FORBIDDEN_INC_DEC_CLASSES): Poison.
> Index: ira-costs.c
> ===================================================================
> --- ira-costs.c (revision 174878)
> +++ ira-costs.c (working copy)
Oops; I spotted a missing comment update.
Please replace these hunks:
> @@ -1685,9 +1651,6 @@ find_costs_and_classes (FILE *dump_file)
> /* Ignore classes that are too small for this operand or
> invalid for an operand that was auto-incremented. */
> if (! contains_reg_of_mode[rclass][PSEUDO_REGNO_MODE (i)]
> -#ifdef FORBIDDEN_INC_DEC_CLASSES
> - || (inc_dec_p && forbidden_inc_dec_class[rclass])
> -#endif
> #ifdef CANNOT_CHANGE_MODE_CLASS
> || invalid_mode_change_p (i, (enum reg_class) rclass)
> #endif
> @@ -1764,9 +1727,6 @@ find_costs_and_classes (FILE *dump_file)
> operand or invalid for an operand that was
> auto-incremented. */
> if (! contains_reg_of_mode[rclass][PSEUDO_REGNO_MODE (i)]
> -#ifdef FORBIDDEN_INC_DEC_CLASSES
> - || (inc_dec_p && forbidden_inc_dec_class[rclass])
> -#endif
> #ifdef CANNOT_CHANGE_MODE_CLASS
> || invalid_mode_change_p (i, (enum reg_class) rclass)
> #endif
with these:
@@ -1682,12 +1648,9 @@ find_costs_and_classes (FILE *dump_file)
for (k = 0; k < cost_classes_ptr->num; k++)
{
rclass = cost_classes[k];
- /* Ignore classes that are too small for this operand or
- invalid for an operand that was auto-incremented. */
+ /* Ignore classes that are too small or invalid for this
+ operand. */
if (! contains_reg_of_mode[rclass][PSEUDO_REGNO_MODE (i)]
-#ifdef FORBIDDEN_INC_DEC_CLASSES
- || (inc_dec_p && forbidden_inc_dec_class[rclass])
-#endif
#ifdef CANNOT_CHANGE_MODE_CLASS
|| invalid_mode_change_p (i, (enum reg_class) rclass)
#endif
@@ -1760,13 +1723,9 @@ find_costs_and_classes (FILE *dump_file)
rclass = cost_classes[k];
if (! ira_class_subset_p[rclass][regno_aclass[i]])
continue;
- /* Ignore classes that are too small for this
- operand or invalid for an operand that was
- auto-incremented. */
+ /* Ignore classes that are too small or invalid
+ for this operand. */
if (! contains_reg_of_mode[rclass][PSEUDO_REGNO_MODE (i)]
-#ifdef FORBIDDEN_INC_DEC_CLASSES
- || (inc_dec_p && forbidden_inc_dec_class[rclass])
-#endif
#ifdef CANNOT_CHANGE_MODE_CLASS
|| invalid_mode_change_p (i, (enum reg_class) rclass)
#endif
brgds, H-P
next prev parent reply other threads:[~2011-06-10 12:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 16:49 Hans-Peter Nilsson
2011-06-09 16:24 ` Vladimir Makarov
2011-06-10 3:46 ` Hans-Peter Nilsson
2011-06-10 13:08 ` Hans-Peter Nilsson [this message]
2011-06-10 14:03 ` Vladimir Makarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.BSF.2.00.1106100827100.52008@dair.pair.com \
--to=hp@bitrange.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=vmakarov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).