Re: [PATCH, Fortran] (Coarray) Change declaration of CAF sync functions.

[Tobias Burnus <burnus@net-b.de>]

On 06/10/2011 11:12 AM, Daniel Carrera wrote:
> This is the patch recently discussed in the GFortran list, now ready 
> for official submission.
> [...]
> 2011-06-07  Daniel Carrera <dcarrera@gmail.com>
>
>     * gfortran.dg/coarray/sync_1.f90: New
>     Test "SYNC ALL", "SYNC MEMORY" and "SYNC IMAGES".
"Test" -> "test for".

> +      /* SYNC ALL           =>   stat == null_pointer_node
> +        SYNC ALL(stat=s)   =>   stat has an integer type
> +
> +         If "stat" has the wrong integer type, use a temp variable of
> +         the right type and later cast the result back into "stat".  */

Intending: The last two lines were space instead of tab-space indented.
Additionally, I think you editor automatically indents lines, which 
causes tailing whitespace in (otherwise) empty lines. I remove those 
(trans-expr.c, mpi.c).

> sync_1.f90:
>
> ! { dg-do run }
> ! { dg-shouldfail "error stop" }

As the ERROR STOP has been removed, the test no longer fails. Hence, 
also the "dg-shouldfail" has to be removed. Otherwise, one gets:

$ make check-gfortran RUNTESTFLAGS='caf.exp=sync_1.f90'
[...]
FAIL: gfortran.dg/coarray/sync_1.f90 -fcoarray=single  -O2  execution test
FAIL: gfortran.dg/coarray/sync_1.f90 -fcoarray=lib  -O2  -lcaf_single 
execution test

It is a frequent problem that one forgets to run the new test cases 
through the testing system, leading to such failures. Or if one did, one 
forgets to do it again after some "trivial" test-case change. ;-)


With those changes, the patch is OK. I have now committed the patch as 
Rev. 174896.

Congratulation to your first GCC patch!

Tobias