public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Georg-Johann Lay <avr@gjlay.de>
To: gcc-patches@gcc.gnu.org
Cc: Jakub Jelinek <jakub@redhat.com>,
	Mike Stump <mikestump@comcast.net>,
	 Kaz Kojima <kkojima@gcc.gnu.org>,
	Rainer Orth <ro@CeBiTec.Uni-Bielefeld.de>
Subject: Re: [testsuite]: Skip tests for targets with int < 32 bits
Date: Tue, 14 Jun 2011 09:38:00 -0000	[thread overview]
Message-ID: <4DF727E4.2010906@gjlay.de> (raw)
In-Reply-To: <20110613182331.GV17079@tyan-ft48-01.lab.bos.redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]

Jakub Jelinek schrieb:
> On Mon, Jun 13, 2011 at 08:18:52PM +0200, Georg-Johann Lay wrote:
>> For exammple, I added this line to, e.g.
>> * gcc.c-torture/execute/cmpsi-2.c
>> * gcc.c-torture/execute/pr45262.c
>> in trunk r172757
>> http://gcc.gnu.org/viewcvs?view=revision&revision=172757
> 
> That was a mistake.
> 
> gcc.c-torture/execute/ doesn't use the dg framework, you need
> to instead add cmpsi-2.x resp. pr45262.x file alongside with
> the testcase.  Look at other *.x files there for details on how they look
> like.
> 
> 	Jakub

Thanks for your help Mike and Jakub.

Updated patch and testrun looks cleaner now.

Johann

--

testsuite/

	* gcc.c-torture/execute/cmpsi-2.c: Undo 172757.
	* gcc.c-torture/execute/cmpsi-2.x: New file.
	* gcc.c-torture/execute/pr45262.c: Undo 172757.
	* gcc.c-torture/execute/pr45262.x: New file.
	* gcc.c-torture/compile/pr46534.c: Skip for AVR.
	* gcc.c-torture/compile/pr49029.c: Add dg-require-effective-target
	int32plus
	* gcc.c-torture/compile/pr49163.c: Ditto.

[-- Attachment #2: testsuite-int32plus-2.diff --]
[-- Type: text/x-patch, Size: 2509 bytes --]

Index: gcc.c-torture/execute/cmpsi-2.c
===================================================================
--- gcc.c-torture/execute/cmpsi-2.c	(Revision 174701)
+++ gcc.c-torture/execute/cmpsi-2.c	(Arbeitskopie)
@@ -1,5 +1,3 @@
-/* { dg-require-effective-target int32plus } */
-
 #define F 140
 #define T 13
 
Index: gcc.c-torture/execute/cmpsi-2.x
===================================================================
--- gcc.c-torture/execute/cmpsi-2.x	(Revision 0)
+++ gcc.c-torture/execute/cmpsi-2.x	(Revision 0)
@@ -0,0 +1,7 @@
+load_lib target-supports.exp
+
+if { [check_effective_target_int16] } {
+	return 1
+}
+
+return 0;
Index: gcc.c-torture/execute/pr45262.c
===================================================================
--- gcc.c-torture/execute/pr45262.c	(Revision 174701)
+++ gcc.c-torture/execute/pr45262.c	(Arbeitskopie)
@@ -1,5 +1,4 @@
 /* PR middle-end/45262 */
-/* { dg-require-effective-target int32plus } */
 
 extern void abort (void);
 
Index: gcc.c-torture/execute/pr45262.x
===================================================================
--- gcc.c-torture/execute/pr45262.x	(Revision 0)
+++ gcc.c-torture/execute/pr45262.x	(Revision 0)
@@ -0,0 +1,7 @@
+load_lib target-supports.exp
+
+if { [check_effective_target_int16] } {
+	return 1
+}
+
+return 0;
Index: gcc.c-torture/compile/pr46534.c
===================================================================
--- gcc.c-torture/compile/pr46534.c	(Revision 174701)
+++ gcc.c-torture/compile/pr46534.c	(Arbeitskopie)
@@ -1,4 +1,4 @@
-/* { dg-skip-if "too big" { pdp11-*-* } { "*" } { "" } } */
+/* { dg-skip-if "too big" { avr-*-* pdp11-*-* } { "*" } { "" } } */
 /* PR middle-end/46534 */
 
 extern int printf (const char *, ...);
Index: gcc.c-torture/compile/pr49029.c
===================================================================
--- gcc.c-torture/compile/pr49029.c	(Revision 174701)
+++ gcc.c-torture/compile/pr49029.c	(Arbeitskopie)
@@ -1,4 +1,5 @@
 /* PR middle-end/49029 */
+/* { dg-require-effective-target int32plus } */
 struct S { volatile unsigned f : 11; signed g : 30; } __attribute__((packed));
 struct T { volatile struct S h; } __attribute__((packed)) a;
 void foo (int);
Index: gcc.c-torture/compile/pr49163.c
===================================================================
--- gcc.c-torture/compile/pr49163.c	(Revision 174701)
+++ gcc.c-torture/compile/pr49163.c	(Arbeitskopie)
@@ -1,4 +1,5 @@
 /* PR target/49163 */
+/* { dg-require-effective-target int32plus } */
 struct S1
 {
  unsigned f0:18;

  reply	other threads:[~2011-06-14  9:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-09 17:21 Georg-Johann Lay
2011-06-13 13:09 ` Ping: " Georg-Johann Lay
2011-06-14 10:10   ` Richard Guenther
2011-06-13 18:04 ` Mike Stump
2011-06-13 18:40   ` Georg-Johann Lay
2011-06-13 18:53     ` Jakub Jelinek
2011-06-14  9:38       ` Georg-Johann Lay [this message]
2011-06-14 15:57         ` Mike Stump
2011-06-13 19:07     ` Mike Stump
2011-06-13 19:09 ` Jakub Jelinek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DF727E4.2010906@gjlay.de \
    --to=avr@gjlay.de \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=kkojima@gcc.gnu.org \
    --cc=mikestump@comcast.net \
    --cc=ro@CeBiTec.Uni-Bielefeld.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).