From: Georg-Johann Lay <avr@gjlay.de>
To: Mike Stump <mikestump@comcast.net>
Cc: gcc-patches@gcc.gnu.org, Kaz Kojima <kkojima@gcc.gnu.org>,
Jakub Jelinek <jakub@redhat.com>,
Rainer Orth <ro@CeBiTec.Uni-Bielefeld.de>
Subject: Re: [testsuite]: Skip tests for targets with int < 32 bits
Date: Mon, 13 Jun 2011 18:40:00 -0000 [thread overview]
Message-ID: <4DF6548C.2030207@gjlay.de> (raw)
In-Reply-To: <691C71AE-DCA3-4061-8904-C6F970618B17@comcast.net>
Mike Stump schrieb:
> On Jun 9, 2011, at 9:27 AM, Georg-Johann Lay wrote:
>
>>This patch fixes testsuite failures because the testcases assume
>>sizeof(int) >= 4.
>>
>> * gcc.c-torture/compile/pr49029.c: Add dg-require-effective-target
>> int32plus
>> * gcc.c-torture/compile/pr49163.c: Ditto.
>
>
> Well, since no one objected to it, I'll approve it. I was hoping that a specific maintainer would approve or reject it. :-(
Who is a "specific maintainer" here?
I found you (and Rainer Orth) as "testsuite" maintainers.
Or does that just refer to the test harness and not to specific test cases?
I CCed Kaz and Jakub because they added respective test cases.
Then I observed that
/* { dg-require-effective-target int32plus } */
does not work as intended for all test cases.
For exammple, I added this line to, e.g.
* gcc.c-torture/execute/cmpsi-2.c
* gcc.c-torture/execute/pr45262.c
in trunk r172757
http://gcc.gnu.org/viewcvs?view=revision&revision=172757
However, these tests are still executed as you can see in
gcc-testresults for trunk r174959:
http://gcc.gnu.org/ml/gcc-testresults/2011-06/msg01429.html
Is this a bug resp. worth a bug report?
Johann
next prev parent reply other threads:[~2011-06-13 18:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 17:21 Georg-Johann Lay
2011-06-13 13:09 ` Ping: " Georg-Johann Lay
2011-06-14 10:10 ` Richard Guenther
2011-06-13 18:04 ` Mike Stump
2011-06-13 18:40 ` Georg-Johann Lay [this message]
2011-06-13 18:53 ` Jakub Jelinek
2011-06-14 9:38 ` Georg-Johann Lay
2011-06-14 15:57 ` Mike Stump
2011-06-13 19:07 ` Mike Stump
2011-06-13 19:09 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF6548C.2030207@gjlay.de \
--to=avr@gjlay.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=kkojima@gcc.gnu.org \
--cc=mikestump@comcast.net \
--cc=ro@CeBiTec.Uni-Bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).