public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jeffreyalaw@gmail.com>
To: Palmer Dabbelt <palmer@rivosinc.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] invoke: RISC-V's -march doesn't take ISA strings
Date: Wed, 16 Nov 2022 21:27:50 -0700	[thread overview]
Message-ID: <4d554ace-be16-f67d-481f-8c045bd78c63@gmail.com> (raw)
In-Reply-To: <20221107185801.326-1-palmer@rivosinc.com>


On 11/7/22 11:58, Palmer Dabbelt wrote:
> The docs say we take ISA strings, but that's never really been the case:
> at a bare minimum we've required lower case strings, but there's
> generally been some subtle differences as well in things like version
> handling and such.  We talked about removing the lower case requirement
> in the last GNU toolchain meeting and we've always called other
> differences just bugs.  We don't have profile support yet, but based on
> the discussions on the RISC-V lists it looks like we're going to have
> some differences there as well.
>
> So let's just stop pretending these are ISA strings.  That's been a
> headache for years now, if we're meant to just be ISA-string-like here
> then we don't have to worry about all these long-tail ISA string parsing
> issues.
>
> Link: https://lists.riscv.org/g/sig-toolchains/message/486
>
> gcc/ChangeLog
>
> 	doc/invoke.texi (RISC-V): -march doesn't take ISA strings.

No strong opinions, mostly because I don't have any of the history.  I'm 
happy to go along with the consensus here.

jeff



      parent reply	other threads:[~2022-11-17  4:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-07 18:58 Palmer Dabbelt
2022-11-08 13:40 ` Christoph Müllner
2022-11-09  3:00   ` Palmer Dabbelt
2022-11-09  9:52     ` Christoph Müllner
2022-11-18  4:29       ` Palmer Dabbelt
2022-11-09 10:19     ` Philipp Tomsich
2022-11-17  4:27 ` Jeff Law [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d554ace-be16-f67d-481f-8c045bd78c63@gmail.com \
    --to=jeffreyalaw@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=palmer@rivosinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).