From: "Ed Catmur" <ed@catmur.uk>
To: "Srinath Parvathaneni" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH v3] emit DW_AT_name for DW_TAG_GNU_formal_parameter_pack [PR70536]
Date: Wed, 17 May 2023 16:32:47 -0500 [thread overview]
Message-ID: <4d962686-1fc9-4903-bea0-971493077bfb@app.fastmail.com> (raw)
In-Reply-To: <20230204165033.4026-1-ed@catmur.uk>
Ping.
On Sat, 4 Feb 2023, at 10:50, Ed Catmur wrote:
> Per
> http://wiki.dwarfstd.org/index.php?title=C%2B%2B0x:_Variadic_templates
> DW_TAG_GNU_formal_parameter_pack should have a DW_AT_name:
>
> 17$: DW_TAG_formal_parameter_pack
> DW_AT_name("args")
> 18$: DW_TAG_formal_parameter
> ! no DW_AT_name attribute
> DW_AT_type(reference to 13$)
> (...)
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70536
> ---
> gcc/dwarf2out.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/dwarf2out.cc b/gcc/dwarf2out.cc
> index 1f39df3b1e2..462328acd9f 100644
> --- a/gcc/dwarf2out.cc
> +++ b/gcc/dwarf2out.cc
> @@ -23041,7 +23041,7 @@ gen_formal_parameter_pack_die (tree parm_pack,
> && subr_die);
>
> parm_pack_die = new_die (DW_TAG_GNU_formal_parameter_pack, subr_die,
> parm_pack);
> - add_src_coords_attributes (parm_pack_die, parm_pack);
> + add_name_and_src_coords_attributes (parm_pack_die, parm_pack);
>
> for (arg = pack_arg; arg; arg = DECL_CHAIN (arg))
> {
> --
> 2.34.1
prev parent reply other threads:[~2023-05-17 21:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-04 16:50 Ed Catmur
2023-05-17 21:32 ` Ed Catmur [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d962686-1fc9-4903-bea0-971493077bfb@app.fastmail.com \
--to=ed@catmur.uk \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).