From: Jason Merrill <jason@redhat.com>
To: Nathaniel Shead <nathanieloshead@gmail.com>, gcc-patches@gcc.gnu.org
Cc: Christophe Lyon <christophe.lyon@linaro.org>,
Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>
Subject: Re: [PATCH] testsuite: Disable test for PR113292 on targets without TLS support
Date: Tue, 23 Jan 2024 16:05:07 -0500 [thread overview]
Message-ID: <4ea916b3-053a-439c-b27a-0468d4119de0@redhat.com> (raw)
In-Reply-To: <65aa27a0.630a0220.e6f95.d004@mx.google.com>
On 1/19/24 02:41, Nathaniel Shead wrote:
> Tested on x86_64-pc-linux-gnu using a cross-compiler to
> arm-unknown-linux-gnueabihf with --enable-threads=0 that the link test
> is correctly skipped. OK for trunk?
OK.
> -- >8 --
>
> This disables the new test added by r14-8168 on machines that don't have
> TLS support, such as bare-metal ARM.
>
> gcc/testsuite/ChangeLog:
>
> * g++.dg/modules/pr113292_c.C: Require TLS.
>
> Signed-off-by: Nathaniel Shead <nathanieloshead@gmail.com>
> ---
> gcc/testsuite/g++.dg/modules/pr113292_c.C | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/gcc/testsuite/g++.dg/modules/pr113292_c.C b/gcc/testsuite/g++.dg/modules/pr113292_c.C
> index aa3f32ae818..c117c7cfcd4 100644
> --- a/gcc/testsuite/g++.dg/modules/pr113292_c.C
> +++ b/gcc/testsuite/g++.dg/modules/pr113292_c.C
> @@ -1,6 +1,8 @@
> // PR c++/113292
> // { dg-module-do link }
> +// { dg-add-options tls }
> // { dg-additional-options "-fmodules-ts" }
> +// { dg-require-effective-target tls_runtime }
>
> import "pr113292_a.H";
>
prev parent reply other threads:[~2024-01-23 21:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 7:41 Nathaniel Shead
2024-01-19 13:47 ` Christophe Lyon
2024-01-23 21:05 ` Jason Merrill [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ea916b3-053a-439c-b27a-0468d4119de0@redhat.com \
--to=jason@redhat.com \
--cc=christophe.lyon@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=maxim.kuvyrkov@linaro.org \
--cc=nathanieloshead@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).