public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Paul E Murphy <murphyp@linux.ibm.com>
To: Thomas Schwinge <thomas@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org, gcc-rust@gcc.gnu.org
Subject: Re: [PATCH 2/2] rust: update usage of TARGET_AIX to TARGET_AIX_OS
Date: Wed, 21 Jun 2023 11:20:46 -0500	[thread overview]
Message-ID: <517783a6-4ce8-77af-6e16-bf49205eec02@linux.ibm.com> (raw)
In-Reply-To: <87a5wv3kxd.fsf@euler.schwinge.homeip.net>



On 6/19/23 3:39 AM, Thomas Schwinge wrote:
> Hi Paul!
> 
> On 2023-06-16T11:00:02-0500, "Paul E. Murphy via Gcc-patches" <gcc-patches@gcc.gnu.org> wrote:
>> This was noticed when fixing the gccgo usage of the macro, the
>> rust usage is very similar.
>>
>> TARGET_AIX is defined as a non-zero value on linux/powerpc64le
>> which may cause unexpected behavior.  TARGET_AIX_OS should be
>> used to toggle AIX specific behavior.
>>
>> gcc/rust/ChangeLog:
>>
>>        * rust-object-export.cc [TARGET_AIX]: Rename and update
>>        usage to TARGET_AIX_OS.
> 
> I don't have rights to formally approve this GCC/Rust change, but I'll
> note that it follows "as obvious" (see
> <https://gcc.gnu.org/gitwrite.html#policies>, "Obvious fixes") to the
> corresponding GCC/Go change, which has been approved:
> <https://inbox.sourceware.org/CAKOQZ8wDWc7G5_jBNK1jvgChhiURceeAmZb5Bqrx_VZjeJP2Vw@mail.gmail.com>,
> and which is where this GCC/Rust code has been copied from, so I suggest
> you push both patches at once.
> 
> 
> Grüße
>   Thomas

Hi Thomas,

Thank you for reviewing.  I do not have commit access, so I cannot push 
this myself.  If this is OK, could one of the rust maintainers push this 
patch?

Thanks,
Paul

  reply	other threads:[~2023-06-21 16:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-16 16:00 [PATCH 1/2] go: " Paul E. Murphy
2023-06-16 16:00 ` [PATCH 2/2] rust: " Paul E. Murphy
2023-06-19  8:39   ` Thomas Schwinge
2023-06-21 16:20     ` Paul E Murphy [this message]
2023-06-22 23:38       ` Peter Bergner
2023-06-16 17:01 ` [PATCH 1/2] go: " Ian Lance Taylor
2023-06-22 23:37   ` Peter Bergner
2023-06-22 23:46     ` Peter Bergner
2023-06-23  3:30       ` Ian Lance Taylor
2023-06-30 17:28         ` Peter Bergner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=517783a6-4ce8-77af-6e16-bf49205eec02@linux.ibm.com \
    --to=murphyp@linux.ibm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gcc-rust@gcc.gnu.org \
    --cc=thomas@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).