From: Jason Merrill <jason@redhat.com>
To: Marek Polacek <polacek@redhat.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Joseph Myers <joseph@codesourcery.com>, Jakub Jelinek <jakub@redhat.com>
Subject: Re: [PATCH] c-family: Fix ICE with -Wsuggest-attribute [PR98487]
Date: Fri, 16 Dec 2022 19:15:06 -0500 [thread overview]
Message-ID: <524ae656-1ab3-090d-8183-8a25f03301aa@redhat.com> (raw)
In-Reply-To: <20221216182817.295303-1-polacek@redhat.com>
On 12/16/22 13:28, Marek Polacek wrote:
> Here we crash because check_function_format was using TREE_PURPOSE
> directly rather than using get_attribute_name.
>
> Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk?
OK.
> PR c/98487
>
> gcc/c-family/ChangeLog:
>
> * c-format.cc (check_function_format): Use get_attribute_name.
>
> gcc/testsuite/ChangeLog:
>
> * c-c++-common/Wsuggest-attribute-1.c: New test.
> ---
> gcc/c-family/c-format.cc | 2 +-
> .../c-c++-common/Wsuggest-attribute-1.c | 36 +++++++++++++++++++
> 2 files changed, 37 insertions(+), 1 deletion(-)
> create mode 100644 gcc/testsuite/c-c++-common/Wsuggest-attribute-1.c
>
> diff --git a/gcc/c-family/c-format.cc b/gcc/c-family/c-format.cc
> index 01adea4ff41..08643c5da7a 100644
> --- a/gcc/c-family/c-format.cc
> +++ b/gcc/c-family/c-format.cc
> @@ -1215,7 +1215,7 @@ check_function_format (const_tree fn, tree attrs, int nargs,
> for (c = TYPE_ATTRIBUTES (TREE_TYPE (current_function_decl));
> c;
> c = TREE_CHAIN (c))
> - if (is_attribute_p ("format", TREE_PURPOSE (c))
> + if (is_attribute_p ("format", get_attribute_name (c))
> && (decode_format_type (IDENTIFIER_POINTER
> (TREE_VALUE (TREE_VALUE (c))))
> == info.format_type))
> diff --git a/gcc/testsuite/c-c++-common/Wsuggest-attribute-1.c b/gcc/testsuite/c-c++-common/Wsuggest-attribute-1.c
> new file mode 100644
> index 00000000000..8b5b398fb78
> --- /dev/null
> +++ b/gcc/testsuite/c-c++-common/Wsuggest-attribute-1.c
> @@ -0,0 +1,36 @@
> +/* PR c/98487 */
> +/* { dg-do compile { target { c || c++11 } } } */
> +/* { dg-options "-Wsuggest-attribute=format" } */
> +
> +#include <stdarg.h>
> +
> +[[gnu::__format__(__printf__, 1, 2)]]
> +void
> +do_printf(const char * const a0, ...)
> +{
> + va_list ap;
> + va_start(ap, a0);
> + __builtin_vprintf(a0, ap);
> + va_end(ap);
> +}
> +
> +[[gnu::__format__(__scanf__, 1, 2)]]
> +void
> +do_scanf(const char * const a0, ...)
> +{
> + va_list ap;
> + va_start(ap, a0);
> + __builtin_vscanf(a0, ap);
> + va_end(ap);
> +}
> +
> +struct tm;
> +
> +[[gnu::__format__(__strftime__, 1, 0)]]
> +void
> +do_strftime(const char * const a0, struct tm * a1)
> +{
> + char buff[256];
> + __builtin_strftime(buff, sizeof(buff), a0, a1);
> + __builtin_puts(buff);
> +}
>
> base-commit: b50fe16a3b2214c418ecc5febc0bb21bc17912b7
prev parent reply other threads:[~2022-12-17 0:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 18:28 Marek Polacek
2022-12-17 0:15 ` Jason Merrill [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524ae656-1ab3-090d-8183-8a25f03301aa@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=joseph@codesourcery.com \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).