public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Robin Dapp <rdapp@linux.ibm.com>
To: gcc-patches@gcc.gnu.org, krebbel@linux.ibm.com
Subject: [PATCH] s390/testsuite: Fix oscbreak-1.c.
Date: Fri, 16 Apr 2021 15:59:39 +0200	[thread overview]
Message-ID: <5278ee53-68ce-3c64-3047-b8d65770aa5a@linux.ibm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

Hi,

checking for an osc break is somewhat brittle especially with many
passes potentially introducing new insns and moving them around.
Therefore, only run the test with -O1 -fschedule-insns in order to limit
the influence of other passes.

Is it OK?

Regards
  Robin

--

gcc/testsuite/ChangeLog:

        * gcc.target/s390/oscbreak-1.c: Compile with -O1
          -fschedule-insns.

[-- Attachment #2: gcc-oscbreak.diff --]
[-- Type: text/x-patch, Size: 725 bytes --]

diff --git a/gcc/testsuite/gcc.target/s390/oscbreak-1.c b/gcc/testsuite/gcc.target/s390/oscbreak-1.c
index fdf356c1fd0..0c612531132 100644
--- a/gcc/testsuite/gcc.target/s390/oscbreak-1.c
+++ b/gcc/testsuite/gcc.target/s390/oscbreak-1.c
@@ -1,5 +1,5 @@
 /* { dg-do compile } */
-/* { dg-options "-O3 -mtune=z13 -dp" } */
+/* { dg-options "-O1 -mtune=z13 -fschedule-insns -dp" } */
 
 void
 foo (char *a, int b)
@@ -10,6 +10,7 @@ foo (char *a, int b)
     a[i] += 1;
 }
 
+/* We should not unconditionally emit an osc_break here.  */
 void
 bar (char *a, int b)
 {
@@ -22,4 +23,4 @@ bar (char *a, int b)
     }
 }
 
-/* { dg-final { scan-assembler "osc_break" } } */
+/* { dg-final { scan-assembler-times "osc_break" 1 } } */

             reply	other threads:[~2021-04-16 13:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-16 13:59 Robin Dapp [this message]
2021-04-20  7:05 ` Andreas Krebbel
2021-05-04 14:13   ` Robin Dapp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5278ee53-68ce-3c64-3047-b8d65770aa5a@linux.ibm.com \
    --to=rdapp@linux.ibm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=krebbel@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).