public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Christophe Lyon <christophe.lyon@arm.com>
To: Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>,
	"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	Richard Earnshaw <Richard.Earnshaw@arm.com>,
	Richard Sandiford <Richard.Sandiford@arm.com>
Subject: Re: [PATCH 01/26] arm: [MVE intrinsics] add binary_widen_opt_n shape
Date: Fri, 12 May 2023 12:38:55 +0200	[thread overview]
Message-ID: <52858881-2f8f-3048-5d94-817132bde531@arm.com> (raw)
In-Reply-To: <PAXPR08MB69267F692B3460A12199D39393759@PAXPR08MB6926.eurprd08.prod.outlook.com>



On 5/12/23 12:17, Kyrylo Tkachov wrote:
> 
> 
>> -----Original Message-----
>> From: Christophe Lyon <christophe.lyon@arm.com>
>> Sent: Friday, May 12, 2023 10:39 AM
>> To: gcc-patches@gcc.gnu.org; Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>;
>> Richard Earnshaw <Richard.Earnshaw@arm.com>; Richard Sandiford
>> <Richard.Sandiford@arm.com>
>> Cc: Christophe Lyon <Christophe.Lyon@arm.com>
>> Subject: [PATCH 01/26] arm: [MVE intrinsics] add binary_widen_opt_n shape
>>
>> This patch adds the binary_widen_opt_n shape description.
> 
> This series is ok with one style nit fixed in this first patch...
> 
>>
>> 2022-12-12  Christophe Lyon  <christophe.lyon@arm.com>
>>
>> 	gcc/
>> 	* config/arm/arm-mve-builtins-shapes.cc (binary_widen_opt_n):
>> New.
>> 	* config/arm/arm-mve-builtins-shapes.h (binary_widen_opt_n): New.
>> ---
>>   gcc/config/arm/arm-mve-builtins-shapes.cc | 49 +++++++++++++++++++++++
>>   gcc/config/arm/arm-mve-builtins-shapes.h  |  1 +
>>   2 files changed, 50 insertions(+)
>>
>> diff --git a/gcc/config/arm/arm-mve-builtins-shapes.cc b/gcc/config/arm/arm-
>> mve-builtins-shapes.cc
>> index 5a299a272f5..ee4bc3f8ea4 100644
>> --- a/gcc/config/arm/arm-mve-builtins-shapes.cc
>> +++ b/gcc/config/arm/arm-mve-builtins-shapes.cc
>> @@ -1098,6 +1098,55 @@ struct binary_widen_n_def : public
>> overloaded_base<0>
>>   };
>>   SHAPE (binary_widen_n)
>>
>> +/* <T0:twice>_t vfoo[_t0](<T0>_t, <T0>_t)
>> +   <T0:twice>_t vfoo[_n_t0](<T0>_t, <S0>_t)
>> +
>> +   Example: vqdmullbq.
>> +   int32x4_t [__arm_]vqdmulltq[_n_s16](int16x8_t a, int16_t b)
>> +   int32x4_t [__arm_]vqdmulltq_m[_n_s16](int32x4_t inactive, int16x8_t a,
>> int16_t b, mve_pred16_t p)
>> +   int32x4_t [__arm_]vqdmulltq[_s16](int16x8_t a, int16x8_t b)
>> +   int32x4_t [__arm_]vqdmulltq_m[_s16](int32x4_t inactive, int16x8_t a,
>> int16x8_t b, mve_pred16_t p)  */
>> +struct binary_widen_opt_n_def : public overloaded_base<0>
>> +{
>> +  void
>> +  build (function_builder &b, const function_group_info &group,
>> +	 bool preserve_user_namespace) const override
>> +  {
>> +    b.add_overloaded_functions (group, MODE_none,
>> preserve_user_namespace);
>> +    build_all (b, "vw0,v0,v0", group, MODE_none,
>> preserve_user_namespace);
>> +    build_all (b, "vw0,v0,s0", group, MODE_n, preserve_user_namespace);
>> +  }
>> +
>> +  tree
>> +  resolve (function_resolver &r) const override
>> +  {
>> +    unsigned int i, nargs;
>> +    type_suffix_index type;
>> +    if (!r.check_gp_argument (2, i, nargs)
>> +	|| (type = r.infer_vector_type (i - 1)) == NUM_TYPE_SUFFIXES)
>> +      return error_mark_node;
>> +
>> +    type_suffix_index wide_suffix
>> +      = find_type_suffix (type_suffixes[type].tclass,
>> +			  type_suffixes[type].element_bits * 2);
>> +
>> +    /* Skip last argument, may be scalar, will be checked below by
>> +       finish_opt_n_resolution.  */
>> +    unsigned int last_arg = i--;
>> +    for (; i > 0; i--)
>> +      if (!r.require_matching_vector_type (i, type))
>> +	return error_mark_node;
>> +
>> +    /* Check the inactive argument has the wide type.  */
>> +    if ((r.pred == PRED_m)
>> +	&& (r.infer_vector_type (0) != wide_suffix))
>> +    return r.report_no_such_form (type);
> 
> Indentation is off here I think.

Indeed!

Thanks,

Christophe

> Thanks,
> Kyrill
> 
>> +
>> +    return r.finish_opt_n_resolution (last_arg, 0, type);
>> +  }
>> +};
>> +SHAPE (binary_widen_opt_n)
>> +
>>   /* Shape for comparison operations that operate on
>>      uniform types.
>>
>> diff --git a/gcc/config/arm/arm-mve-builtins-shapes.h b/gcc/config/arm/arm-
>> mve-builtins-shapes.h
>> index a28cd6a1547..07b12b4af68 100644
>> --- a/gcc/config/arm/arm-mve-builtins-shapes.h
>> +++ b/gcc/config/arm/arm-mve-builtins-shapes.h
>> @@ -53,6 +53,7 @@ namespace arm_mve
>>       extern const function_shape *const binary_rshift_narrow;
>>       extern const function_shape *const binary_rshift_narrow_unsigned;
>>       extern const function_shape *const binary_widen_n;
>> +    extern const function_shape *const binary_widen_opt_n;
>>       extern const function_shape *const cmp;
>>       extern const function_shape *const create;
>>       extern const function_shape *const inherent;
>> --
>> 2.34.1
> 

      reply	other threads:[~2023-05-12 10:39 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-12  9:38 Christophe Lyon
2023-05-12  9:38 ` [PATCH 02/26] arm: [MVE intrinsics] factorize vqdmullbq vqdmulltq Christophe Lyon
2023-05-12  9:38 ` [PATCH 03/26] arm: [MVE intrinsics] rework " Christophe Lyon
2023-05-12  9:38 ` [PATCH 04/26] arm: [MVE intrinsics] factorize vrmlaldavhaq vrmlaldavhaxq vrmlsldavhaq vrmlsldavhaxq Christophe Lyon
2023-05-12  9:38 ` [PATCH 05/26] arm: [MVE intrinsics] rework " Christophe Lyon
2023-05-12  9:38 ` [PATCH 06/26] arm: [MVE intrinsics] add binary_lshift_unsigned shape Christophe Lyon
2023-05-12  9:38 ` [PATCH 07/26] arm: [MVE intrinsics] factorize vqshluq Christophe Lyon
2023-05-12  9:38 ` [PATCH 08/26] arm: [MVE intrinsics] rework vqshluq Christophe Lyon
2023-05-12  9:38 ` [PATCH 09/26] arm: [MVE intrinsics] add binary_imm32 shape Christophe Lyon
2023-05-12  9:38 ` [PATCH 10/26] arm: [MVE intrinsics] factorize vrbsrq Christophe Lyon
2023-05-12  9:38 ` [PATCH 11/26] arm: [MVE intrinsics] rework vbrsrq Christophe Lyon
2023-05-12  9:38 ` [PATCH 12/26] arm: [MVE intrinsics] add mvn shape Christophe Lyon
2023-05-12  9:38 ` [PATCH 13/26] arm: [MVE intrinsics] factorize vmvnq Christophe Lyon
2023-05-12  9:38 ` [PATCH 14/26] arm: [MVE intrinsics] rework vmvnq Christophe Lyon
2023-05-12  9:38 ` [PATCH 15/26] arm: [MVE intrinsics] add ternary_opt_n shape Christophe Lyon
2023-05-12  9:38 ` [PATCH 16/26] arm: [MVE intrinsics] factorize vfmaq vfmsq vfmasq Christophe Lyon
2023-05-12  9:38 ` [PATCH 17/26] arm: [MVE intrinsics] rework vfmaq vfmasq vfmsq Christophe Lyon
2023-05-12  9:38 ` [PATCH 18/26] arm: [MVE intrinsics] factorize vpselq Christophe Lyon
2023-05-12  9:38 ` [PATCH 19/26] arm: [MVE intrinsics] add vpsel shape Christophe Lyon
2023-05-12  9:38 ` [PATCH 20/26] arm: [MVE intrinsics] rework vpselq Christophe Lyon
2023-05-12  9:38 ` [PATCH 21/26] arm: [MVE intrinsics] add ternary_lshift shape Christophe Lyon
2023-05-12  9:38 ` [PATCH 22/26] arm: [MVE intrinsics] factorize vsliq Christophe Lyon
2023-05-12  9:38 ` [PATCH 23/26] arm: [MVE intrinsics] rework vsliq Christophe Lyon
2023-05-12  9:38 ` [PATCH 24/26] arm: [MVE intrinsics] add ternary_rshift shape Christophe Lyon
2023-05-12  9:38 ` [PATCH 25/26] arm: [MVE intrinsics] factorize vsriq Christophe Lyon
2023-05-12  9:38 ` [PATCH 26/26] arm: [MVE intrinsics] rework vsriq Christophe Lyon
2023-05-12 10:17 ` [PATCH 01/26] arm: [MVE intrinsics] add binary_widen_opt_n shape Kyrylo Tkachov
2023-05-12 10:38   ` Christophe Lyon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52858881-2f8f-3048-5d94-817132bde531@arm.com \
    --to=christophe.lyon@arm.com \
    --cc=Kyrylo.Tkachov@arm.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=Richard.Sandiford@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).