* [PATCH] ira: Remove duplicate `memset' over `full_costs' from `assign_hard_reg'
@ 2022-11-14 23:21 Maciej W. Rozycki
2022-11-15 0:11 ` Jeff Law
0 siblings, 1 reply; 3+ messages in thread
From: Maciej W. Rozycki @ 2022-11-14 23:21 UTC (permalink / raw)
To: gcc-patches; +Cc: Vladimir Makarov
Remove duplicate clearing of `full_costs' made in `assign_hard_reg',
which has been there since the beginning, i.e. commit 058e97ecf33a
("IRA has been merged into trunk"),
<https://gcc.gnu.org/ml/gcc-patches/2008-08/msg01932.html>.
gcc/
* ira-color.cc (assign_hard_reg): Remove duplicate `memset' over
`full_costs'.
---
Hi,
I find this fairly obvious, OK to apply?
Maciej
---
gcc/ira-color.cc | 1 -
1 file changed, 1 deletion(-)
gcc-ira-assign-hard-reg-full-costs-dup.diff
Index: gcc/gcc/ira-color.cc
===================================================================
--- gcc.orig/gcc/ira-color.cc
+++ gcc/gcc/ira-color.cc
@@ -1961,7 +1961,6 @@ assign_hard_reg (ira_allocno_t a, bool r
aclass = ALLOCNO_CLASS (a);
class_size = ira_class_hard_regs_num[aclass];
best_hard_regno = -1;
- memset (full_costs, 0, sizeof (int) * class_size);
mem_cost = 0;
memset (costs, 0, sizeof (int) * class_size);
memset (full_costs, 0, sizeof (int) * class_size);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ira: Remove duplicate `memset' over `full_costs' from `assign_hard_reg'
2022-11-14 23:21 [PATCH] ira: Remove duplicate `memset' over `full_costs' from `assign_hard_reg' Maciej W. Rozycki
@ 2022-11-15 0:11 ` Jeff Law
2022-11-15 11:24 ` Maciej W. Rozycki
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Law @ 2022-11-15 0:11 UTC (permalink / raw)
To: Maciej W. Rozycki, gcc-patches; +Cc: Vladimir Makarov
On 11/14/22 16:21, Maciej W. Rozycki wrote:
> Remove duplicate clearing of `full_costs' made in `assign_hard_reg',
> which has been there since the beginning, i.e. commit 058e97ecf33a
> ("IRA has been merged into trunk"),
> <https://gcc.gnu.org/ml/gcc-patches/2008-08/msg01932.html>.
>
> gcc/
> * ira-color.cc (assign_hard_reg): Remove duplicate `memset' over
> `full_costs'.
> ---
> Hi,
>
> I find this fairly obvious, OK to apply?
Seems obvious to me as well. OK.
jeff
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ira: Remove duplicate `memset' over `full_costs' from `assign_hard_reg'
2022-11-15 0:11 ` Jeff Law
@ 2022-11-15 11:24 ` Maciej W. Rozycki
0 siblings, 0 replies; 3+ messages in thread
From: Maciej W. Rozycki @ 2022-11-15 11:24 UTC (permalink / raw)
To: Jeff Law; +Cc: gcc-patches, Vladimir Makarov
On Mon, 14 Nov 2022, Jeff Law wrote:
> > gcc/
> > * ira-color.cc (assign_hard_reg): Remove duplicate `memset' over
> > `full_costs'.
> > ---
> > Hi,
> >
> > I find this fairly obvious, OK to apply?
>
> Seems obvious to me as well. OK.
Thanks, now committed.
Maciej
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-15 11:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-14 23:21 [PATCH] ira: Remove duplicate `memset' over `full_costs' from `assign_hard_reg' Maciej W. Rozycki
2022-11-15 0:11 ` Jeff Law
2022-11-15 11:24 ` Maciej W. Rozycki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).