From: Xi Ruoyao <xry111@xry111.site>
To: WANG Xuerui <i@xen0n.name>, Chenghua Xu <xuchenghua@loongson.cn>,
gcc-patches@gcc.gnu.org, Lulu Cheng <chenglulu@loongson.cn>
Cc: Jinyang He <hejinyang@loongson.cn>,
Huacai Chen <chenhuacai@kernel.org>,
Youling Tang <tangyouling@loongson.cn>
Subject: Re: [PATCH v5] LoongArch: add movable attribute
Date: Wed, 03 Aug 2022 11:15:24 +0800 [thread overview]
Message-ID: <55204c3cbb887673e6ec1ece3d19af90d242fd5b.camel@xry111.site> (raw)
In-Reply-To: <dda38a93-848a-1734-5a1a-a09d55802305@xen0n.name>
On Wed, 2022-08-03 at 10:59 +0800, WANG Xuerui wrote:
> I don't think mindlessly caring for vendor forks is always correct. In
> fact I find the name "movable" too generic, and something like
> "force_got_access" could be better.
The problem is "what will this behave *if* we later add some code model
without GOT". If it's named "movable" we generate a full 4-instruction
absolute (or PC-relative) address loading sequence if GOT is disabled.
If it's named "force_got_access" we report an error and reject the code
if GOT is disabled.
> I don't currently have time to test this, unfortunately, due to day job.
> Might be able to give it a whirl one or two week later though...
Unfortunately, I can't access my dev system via SSH too because while
I'm remote, a sudden power surge happened and I forgot to configure an
automatically power-on.
I'm kind of rushy because I want to make it into 12.2, leaving 12.1 the
only exception cannot build Linux >= 6.0. But maybe it just can't be
backported anyway.
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2022-08-03 3:15 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 14:22 [PATCH] LoongArch: add addr_global attribute Xi Ruoyao
2022-07-29 15:31 ` [PATCH v2] " Xi Ruoyao
2022-07-29 17:17 ` [PATCH v3] " Xi Ruoyao
2022-07-30 3:13 ` Lulu Cheng
2022-07-30 6:03 ` Huacai Chen
2022-07-31 9:05 ` Chenghua Xu
2022-08-01 10:04 ` [PATCH v4] LoongArch: add movable attribute Xi Ruoyao
2022-08-01 10:07 ` [PATCH v5] " Xi Ruoyao
2022-08-03 1:36 ` Xi Ruoyao
2022-08-03 2:59 ` WANG Xuerui
2022-08-03 3:15 ` Xi Ruoyao [this message]
[not found] ` <-2muj1c-68saz6jhkcyw3jo1xp-1mgcvnkbqi2wjp6tue-qsso54-emxgu3-k85590-kpgox7-w67u6h3cai1l-5bi887dsgzsu-g4d7i7-wl316qxrucx4kv4on7-mnna36-iremg8-nwc5ot-9041t2-hu8nsl.1659495047941@email.android.com>
2022-08-03 3:10 ` 回复：[PATCH " Xi Ruoyao
2022-08-04 7:47 ` Xi Ruoyao
2022-08-05 1:05 ` Lulu Cheng
2022-08-05 1:28 ` Xi Ruoyao
2022-08-05 2:38 ` Lulu Cheng
2022-08-05 2:51 ` Xi Ruoyao
2022-08-05 3:34 ` Xi Ruoyao
2022-08-05 3:45 ` Xi Ruoyao
2022-08-05 4:01 ` Lulu Cheng
2022-08-05 6:03 ` Xi Ruoyao
2022-08-05 7:19 ` Lulu Cheng
2022-08-05 7:41 ` WANG Xuerui
2022-08-05 7:58 ` Lulu Cheng
2022-08-05 9:53 ` Xi Ruoyao
2022-08-08 4:53 ` Lulu Cheng
2022-08-09 11:30 ` Xi Ruoyao
2022-08-09 13:03 ` Lulu Cheng
2022-08-09 14:04 ` Xi Ruoyao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55204c3cbb887673e6ec1ece3d19af90d242fd5b.camel@xry111.site \
--to=xry111@xry111.site \
--cc=chenglulu@loongson.cn \
--cc=chenhuacai@kernel.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=hejinyang@loongson.cn \
--cc=i@xen0n.name \
--cc=tangyouling@loongson.cn \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).