public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [gomp4] Fixacc_on_device xform
@ 2015-08-19 17:43 Nathan Sidwell
  0 siblings, 0 replies; only message in thread
From: Nathan Sidwell @ 2015-08-19 17:43 UTC (permalink / raw)
  To: GCC Patches; +Cc: Cesar Philippidis, james norris

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

I've committed this fix for a typo I introduced yesterday (and not testing what 
I thought I was testing).  Sadly passing a gimple_seq to gsi_replace doesn't 
lead to a compile error, but to bad runtime behaviour.

nathan

[-- Attachment #2: gomp4-xform-fix.patch --]
[-- Type: text/x-patch, Size: 863 bytes --]

2015-08-19  Nathan Sidwell  <nathan@codesourcery.com>

	* omp-low.c (oacc_xform_on_device): Fix thinko in previous change.

Index: gcc/omp-low.c
===================================================================
--- gcc/omp-low.c	(revision 226986)
+++ gcc/omp-low.c	(working copy)
@@ -14619,14 +14621,14 @@ oacc_xform_on_device (gimple stmt)
 #endif
   result = fold_convert (integer_type_node, result);
   tree lhs = gimple_call_lhs (stmt);
-  gimple_seq replace = NULL;
+  gimple_seq seq = NULL;
 
   push_gimplify_context (true);
-  gimplify_assign (lhs, result, &replace);
+  gimplify_assign (lhs, result, &seq);
   pop_gimplify_context (NULL);
 
   gimple_stmt_iterator gsi = gsi_for_stmt (stmt);
-  gsi_replace (&gsi, replace, false);
+  gsi_replace_with_seq (&gsi, seq, false);
 }
 
 /* Transform oacc_dim_size and oacc_dim_pos internal function calls to

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-08-19 17:38 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-19 17:43 [gomp4] Fixacc_on_device xform Nathan Sidwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).