public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] mark libstdc++ tests unsupported if they fail with "relocation truncated"
@ 2015-10-13  9:12 Szabolcs Nagy
  2015-10-15 10:15 ` Jonathan Wakely
  0 siblings, 1 reply; 2+ messages in thread
From: Szabolcs Nagy @ 2015-10-13  9:12 UTC (permalink / raw)
  To: libstdc++, gcc-patches

[-- Attachment #1: Type: text/plain, Size: 715 bytes --]

Dejagnu tweak:
Check the compiler output in libstdc++-dg-test using
${tool}_check_unsupported_p and mark the output
unsupported accordingly to avoid "relocation truncated"
failures cluttering the test results on aarch64-none-elf
with -mcmodel=tiny. (gcc torture tests already use this
predicate for this reason.)

This is a revision of
https://gcc.gnu.org/ml/libstdc++/2015-01/msg00198.html
which had problems because the unsupported result was
propagated to and handled by dg-runtest differently
than expected.

Is it OK?

libstdc++-v3/Changelog:

2015-10-13  Szabolcs Nagy  <szabolcs.nagy@arm.com>

	* testsuite/lib/libstdc++.exp (libstdc++-dg-test): Check for
	unsupported compiler output.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: reloc_trunc_dg.diff --]
[-- Type: text/x-patch; name=reloc_trunc_dg.diff, Size: 704 bytes --]

diff --git a/libstdc++-v3/testsuite/lib/libstdc++.exp b/libstdc++-v3/testsuite/lib/libstdc++.exp
index 88738b7..769ac94 100644
--- a/libstdc++-v3/testsuite/lib/libstdc++.exp
+++ b/libstdc++-v3/testsuite/lib/libstdc++.exp
@@ -409,6 +409,11 @@ proc libstdc++-dg-test { prog do_what extra_tool_flags } {
     # and-target file), but the defaults are lacking in goodness.
     set comp_output [$select_compile "$prog" "$output_file" "$compile_type" $options];
 
+    set unsupported_message [libstdc++_check_unsupported_p $comp_output]
+    if { $unsupported_message != "" } {
+	set comp_output "::unsupported::$unsupported_message"
+    }
+
     return [list $comp_output $output_file]
 }
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mark libstdc++ tests unsupported if they fail with "relocation truncated"
  2015-10-13  9:12 [PATCH] mark libstdc++ tests unsupported if they fail with "relocation truncated" Szabolcs Nagy
@ 2015-10-15 10:15 ` Jonathan Wakely
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Wakely @ 2015-10-15 10:15 UTC (permalink / raw)
  To: Szabolcs Nagy; +Cc: libstdc++, gcc-patches

On 13/10/15 10:12 +0100, Szabolcs Nagy wrote:
>Dejagnu tweak:
>Check the compiler output in libstdc++-dg-test using
>${tool}_check_unsupported_p and mark the output
>unsupported accordingly to avoid "relocation truncated"
>failures cluttering the test results on aarch64-none-elf
>with -mcmodel=tiny. (gcc torture tests already use this
>predicate for this reason.)
>
>This is a revision of
>https://gcc.gnu.org/ml/libstdc++/2015-01/msg00198.html
>which had problems because the unsupported result was
>propagated to and handled by dg-runtest differently
>than expected.
>
>Is it OK?

OK, assuming this was tested on a primary platform and didn't change
the libstdc++ testresults.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-10-15 10:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-13  9:12 [PATCH] mark libstdc++ tests unsupported if they fail with "relocation truncated" Szabolcs Nagy
2015-10-15 10:15 ` Jonathan Wakely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).