[PATCH, i386] PR68497. Fix ICE with -fno-checking

[PATCH, i386] PR68497. Fix ICE with -fno-checking

[Mikhail Maltsev]

[-- Attachment #1: Type: text/plain, Size: 603 bytes --]

Hi!

The attached patch fixes a problem introduced in r229567: the assertion

gcc_assert (is_sse);

is checked if flag_checking is false, and this causes an ICE when compiling with
-fno-checking.

Bootstrapped and regtested on x86_64-pc-linux-gnu. OK for trunk?

-- 
Regards,
    Mikhail Maltsev

gcc/ChangeLog:

2015-11-23  Mikhail Maltsev  <maltsevm@gmail.com>

	PR target/68497
	* config/i386/i386.c (output_387_binary_op): Fix assertion for
	-fno-checking case.

gcc/testsuite/ChangeLog:

2015-11-23  Mikhail Maltsev  <maltsevm@gmail.com>

	PR target/68497
	* gcc.target/i386/pr68497.c: New test.



[-- Attachment #2: pr68497.patch --]
[-- Type: text/x-patch, Size: 1715 bytes --]

diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
index 83749d5..23dbb3a 100644
--- a/gcc/config/i386/i386.c
+++ b/gcc/config/i386/i386.c
@@ -17675,18 +17675,20 @@ output_387_binary_op (rtx insn, rtx *operands)
 
   /* Even if we do not want to check the inputs, this documents input
      constraints.  Which helps in understanding the following code.  */
-  if (flag_checking
-      && STACK_REG_P (operands[0])
-      && ((REG_P (operands[1])
-	   && REGNO (operands[0]) == REGNO (operands[1])
-	   && (STACK_REG_P (operands[2]) || MEM_P (operands[2])))
-	  || (REG_P (operands[2])
-	      && REGNO (operands[0]) == REGNO (operands[2])
-	      && (STACK_REG_P (operands[1]) || MEM_P (operands[1]))))
-      && (STACK_TOP_P (operands[1]) || STACK_TOP_P (operands[2])))
-    ; /* ok */
-  else
-    gcc_checking_assert (is_sse);
+  if (flag_checking)
+    {
+      if (STACK_REG_P (operands[0])
+	  && ((REG_P (operands[1])
+	       && REGNO (operands[0]) == REGNO (operands[1])
+	       && (STACK_REG_P (operands[2]) || MEM_P (operands[2])))
+	      || (REG_P (operands[2])
+		  && REGNO (operands[0]) == REGNO (operands[2])
+		  && (STACK_REG_P (operands[1]) || MEM_P (operands[1]))))
+	  && (STACK_TOP_P (operands[1]) || STACK_TOP_P (operands[2])))
+	; /* ok */
+      else
+	gcc_assert (is_sse);
+    }
 
   switch (GET_CODE (operands[3]))
     {
diff --git a/gcc/testsuite/gcc.target/i386/pr68497.c b/gcc/testsuite/gcc.target/i386/pr68497.c
new file mode 100644
index 0000000..0135cda
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr68497.c
@@ -0,0 +1,8 @@
+/* { dg-do compile } */
+/* { dg-options "-fno-checking" } */
+
+long double
+foo (long double x, long double y)
+{
+  return x + y;
+}

Re: [PATCH, i386] PR68497. Fix ICE with -fno-checking

[Bernd Schmidt]

On 11/24/2015 12:09 AM, Mikhail Maltsev wrote:
> The attached patch fixes a problem introduced in r229567: the assertion
>
> gcc_assert (is_sse);
>
> is checked if flag_checking is false, and this causes an ICE when compiling with
> -fno-checking.
>
Ok.


Bernd

Re: [PATCH, i386] PR68497. Fix ICE with -fno-checking

[Mikhail Maltsev]

On 11/24/2015 02:43 AM, Bernd Schmidt wrote:
> On 11/24/2015 12:09 AM, Mikhail Maltsev wrote:
>> The attached patch fixes a problem introduced in r229567: the assertion
>>
>> gcc_assert (is_sse);
>>
>> is checked if flag_checking is false, and this causes an ICE when
>> compiling with
>> -fno-checking.
>>
> Ok.
> 
> 
> Bernd
> 

Committed as r230803.

-- 
Regards,
    Mikhail Maltsev