From: Indu Bhagat <indu.bhagat@oracle.com>
To: David Faust <david.faust@oracle.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH v2 0/3] btf: fix BTF for extern items [PR106773]
Date: Tue, 13 Dec 2022 23:08:57 -0800 [thread overview]
Message-ID: <56aad541-656d-c8e2-4691-5e2ccad55678@oracle.com> (raw)
In-Reply-To: <20221213184426.8861-1-david.faust@oracle.com>
On 12/13/22 10:44, David Faust wrote:
> [Changes from v1:
> - Remove #defines for LINKAGE_* values, instead mirror enums from
> linux/btf.h to include/btf.h and use those.
> - Fix BTF generation for extern variable with both non-defining and
> defining decls in the same CU. Add a test for this.
> - Update several comments per review feedback. ]
>
> Hi,
>
> This series fixes the issues reported in target/PR106773. I decided to
> split it into three commits, as there are ultimately three distinct
> issues and fixes. See each patch for details.
>
> Tested on bpf-unknown-none and x86_64-linux-gnu, no known regressions.
>
> OK to push?
> Thanks.
>
Hi David,
LGTM.
Thanks
> David Faust (3):
> btf: add 'extern' linkage for variables [PR106773]
> btf: fix 'extern const void' variables [PR106773]
> btf: correct generation for extern funcs [PR106773]
>
> gcc/btfout.cc | 184 +++++++++++++-----
> .../gcc.dg/debug/btf/btf-datasec-2.c | 28 +++
> .../gcc.dg/debug/btf/btf-function-6.c | 19 ++
> gcc/testsuite/gcc.dg/debug/btf/btf-pr106773.c | 25 +++
> .../gcc.dg/debug/btf/btf-variables-4.c | 24 +++
> .../gcc.dg/debug/btf/btf-variables-5.c | 19 ++
> include/btf.h | 29 ++-
> 7 files changed, 276 insertions(+), 52 deletions(-)
> create mode 100644 gcc/testsuite/gcc.dg/debug/btf/btf-datasec-2.c
> create mode 100644 gcc/testsuite/gcc.dg/debug/btf/btf-function-6.c
> create mode 100644 gcc/testsuite/gcc.dg/debug/btf/btf-pr106773.c
> create mode 100644 gcc/testsuite/gcc.dg/debug/btf/btf-variables-4.c
> create mode 100644 gcc/testsuite/gcc.dg/debug/btf/btf-variables-5.c
>
prev parent reply other threads:[~2022-12-14 7:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 18:44 David Faust
2022-12-13 18:44 ` [PATCH v2 1/3] btf: add 'extern' linkage for variables [PR106773] David Faust
2022-12-13 18:44 ` [PATCH v2 2/3] btf: fix 'extern const void' " David Faust
2022-12-13 18:44 ` [PATCH v2 3/3] btf: correct generation for extern funcs [PR106773] David Faust
2022-12-14 7:08 ` Indu Bhagat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56aad541-656d-c8e2-4691-5e2ccad55678@oracle.com \
--to=indu.bhagat@oracle.com \
--cc=david.faust@oracle.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).