Re: [PATCH 1/2] analyzer: show close event for use_after_close diagnostic

[David Malcolm <dmalcolm@redhat.com>]

On Tue, 2022-07-05 at 23:07 +0530, Mir Immad wrote:

[...snip...]

>  gcc/analyzer/sm-fd.cc                | 13 +++++++++++--
>  gcc/testsuite/gcc.dg/analyzer/fd-4.c |  4 ++--
>  2 files changed, 13 insertions(+), 4 deletions(-)
> 
> diff --git a/gcc/analyzer/sm-fd.cc b/gcc/analyzer/sm-fd.cc
> index 4058ac53308..a85c95cc502 100644
> --- a/gcc/analyzer/sm-fd.cc
> +++ b/gcc/analyzer/sm-fd.cc
> @@ -454,7 +454,10 @@ public:
>        return label_text::borrow ("opened here");
> 
>      if (change.m_new_state == m_sm.m_closed)
> +    {
> +      m_first_close_event = change.m_event_id;
>         return change.formatted_print ("closed here");
> +    }

Looks like the indentation isn't quite right here, or did the patch get
mangled during the emailing process?

[...snip...]


Otherwise, the patch looks good.

Thanks
Dave