From: Qing Zhao <qing.zhao@oracle.com>
To: Joseph Myers <joseph@codesourcery.com>,
Richard Biener <rguenther@suse.de>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
martin Sebor <msebor@gmail.com>, jakub Jelinek <jakub@redhat.com>,
Kees Cook <keescook@chromium.org>
Subject: Re: [GCC13][Patch][V6][PATCH 1/2] Add a new option -fstrict-flex-arrays[=n] and new attribute strict_flex_array
Date: Thu, 6 Oct 2022 12:49:59 +0000 [thread overview]
Message-ID: <5C0AB68D-9014-44A6-A991-111EB91AF33C@oracle.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2210052022570.917581@digraph.polyomino.org.uk>
> On Oct 5, 2022, at 4:25 PM, Joseph Myers <joseph@codesourcery.com> wrote:
>
> On Wed, 5 Oct 2022, Qing Zhao via Gcc-patches wrote:
>
>> + /* if not the last field, return false. */
>
> Comments should start with an uppercase letter.
>
>> + /* if not an array field, return false. */
>
>> + /* if there is a strict_flex_array attribute attached to the field,
>> + override the flag_strict_flex_arrays. */
>
>> + /* get the value of the level first from the attribute. */
>
>> + /* the attribute has higher priority than flag_struct_flex_array. */
>
>> + /* default, all trailing arrays are flexiable array members. */
>
> Likewise, and "flexible" not "flexiable".
>
>> + /* whether this field is the last field of the structure or union.
>> + for UNION, any field is the last field of it. */
>
> Likewise.
>
>> +field of a structure as a flexible array member for the purposesof accessing
>
> Missing space, should be "purposes of".
Will fix all the above.
>
> The C front-end and docs changes are OK with the fixes above.
Thanks a lot.
So this patch is considered approved, I will commit it after the above fix and one more round of testing.
Let me know if you have more comment.
Qing
>
> --
> Joseph S. Myers
> joseph@codesourcery.com
next prev parent reply other threads:[~2022-10-06 12:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 19:13 [GCC13][Patch][V6][PATCH 0/2] Add a new option -fstrict-flex-arrays[=n] and attribute strict_flex_array(n) and use it in PR101836 Qing Zhao
2022-10-05 19:13 ` [GCC13][Patch][V6][PATCH 1/2] Add a new option -fstrict-flex-arrays[=n] and new attribute strict_flex_array Qing Zhao
2022-10-05 20:25 ` Joseph Myers
2022-10-06 12:49 ` Qing Zhao [this message]
2022-10-07 17:49 ` Qing Zhao
2022-10-05 19:13 ` [GCC13][Patch][V6][PATCH 2/2] Use array_at_struct_end_p in __builtin_object_size [PR101836] Qing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C0AB68D-9014-44A6-A991-111EB91AF33C@oracle.com \
--to=qing.zhao@oracle.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=joseph@codesourcery.com \
--cc=keescook@chromium.org \
--cc=msebor@gmail.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).