From: Jeff Law <jeffreyalaw@gmail.com>
To: Aldy Hernandez <aldyh@redhat.com>, Jakub Jelinek <jakub@redhat.com>
Cc: GCC patches <gcc-patches@gcc.gnu.org>,
Andrew MacLeod <amacleod@redhat.com>
Subject: Re: [PATCH] [range-ops] Minor readability fix.
Date: Wed, 16 Nov 2022 19:15:38 -0700 [thread overview]
Message-ID: <5a93e732-3fcc-239c-7c77-a573ffd1f236@gmail.com> (raw)
In-Reply-To: <20221115163135.604240-1-aldyh@redhat.com>
On 11/15/22 09:31, Aldy Hernandez via Gcc-patches wrote:
> I know it's past the end of stage1, but I'm afraid we'll drag this
> around forever in the GCC12 branch, and it's an easy readbility fix.
>
> p.s. Or if you prefer:
>
> if (!lb_nan && !ub_nan && !maybe_nan && ....)
> r.clear_nan ();
>
> OK for trunk?
>
> gcc/ChangeLog:
>
> * range-op-float.cc (range_operator_float::fold_range): Make check
> for maybe_isnan more readable.
Your call. I think we're so early in stage3 that if you think this is
uber-safe go for it.
jeff
prev parent reply other threads:[~2022-11-17 2:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 16:31 Aldy Hernandez
2022-11-17 2:15 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a93e732-3fcc-239c-7c77-a573ffd1f236@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=aldyh@redhat.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).