public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Xi Ruoyao <xry111@xry111.site>
To: Lulu Cheng <chenglulu@loongson.cn>, gcc-patches@gcc.gnu.org
Cc: i@xen0n.name, xuchenghua@loongson.cn
Subject: Re: [PATCH v3] LoongArch: Optimize immediate load.
Date: Fri, 04 Nov 2022 10:22:57 +0800	[thread overview]
Message-ID: <5b19fb73fc15ae68951118a96393ed2222b41190.camel@xry111.site> (raw)
In-Reply-To: <20221101120444.412376-1-chenglulu@loongson.cn>

On Tue, 2022-11-01 at 20:04 +0800, Lulu Cheng wrote:
> gcc/ChangeLog:
> 
>         * config/loongarch/constraints.md (x): New constraint.
>         * config/loongarch/loongarch.cc (struct loongarch_address_info):
>         Adds a method to load the immediate 32 to 64 bit field.
>         (struct loongarch_integer_op): Define a new member curr_value,
>         that records the value of the number stored in the destination
>         register immediately after the current instruction has run.
>         (LARCH_MAX_INTEGER_OPS): Define this macro as 3.
>         (LU32I_B): Move to the loongarch.h.
>         (LU52I_B): Likewise.
>         (loongarch_build_integer): Adds a method to load the immediate
>         32 to 63 bits.
>         (loongarch_move_integer): Likewise.

We need to mention "call set_unique_reg_note" here because it seems the
key to resolve the issue.

Otherwise LGTM.

>         (loongarch_print_operand_reloc): Modifying comment information.
>         * config/loongarch/loongarch.h (LU32I_B): Move from loongarch.cc.
>         (LU52I_B): Likewise.
>         (HWIT_UC_0xFFFFFFFF): New macro.
>         (HI32_OPERAND): New macro.
>         * config/loongarch/loongarch.md (load_hi32): New template.
>         * config/loongarch/predicates.md (const_hi32_operand): Determines
>         whether the value is an immediate number that has a value of only
>         the higher 32 bits.
>         (hi32_mask_operand): Immediately counts the mask of 32 to 61 bits.

-- 
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University

  reply	other threads:[~2022-11-04  2:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-01 12:04 Lulu Cheng
2022-11-04  2:22 ` Xi Ruoyao [this message]
2022-11-04  2:33   ` Lulu Cheng
2022-11-04  2:56     ` Xi Ruoyao
2022-11-04  3:07       ` Lulu Cheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b19fb73fc15ae68951118a96393ed2222b41190.camel@xry111.site \
    --to=xry111@xry111.site \
    --cc=chenglulu@loongson.cn \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=i@xen0n.name \
    --cc=xuchenghua@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).