public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jeffreyalaw@gmail.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
	gcc-patches@gcc.gnu.org
Subject: Re: [PATCH v2] libcpp: Avoid remapping filenames within directives
Date: Fri, 18 Nov 2022 13:14:54 -0700	[thread overview]
Message-ID: <5d9f6221-a088-35b7-8e3b-5fc1a86b5f07@gmail.com> (raw)
In-Reply-To: <20221102104713.643862-1-richard.purdie@linuxfoundation.org>


On 11/2/22 04:47, Richard Purdie via Gcc-patches wrote:
> Code such as:
>
>   #include __FILE__
>
> can interact poorly with the *-prefix-map options when cross compiling. In
> general you're after to remap filenames for use in target context but the
> local paths should be used to find include files at compile time. Ingoring
> filename remapping for directives allows avoiding such failures.
>
> Fix this to improve such usage and then document this against file-prefix-map
> (referenced by the other *-prefix-map options) to make the behaviour clear
> and defined.
>
> libcpp/ChangeLog:
>
>      * macro.cc (_cpp_builtin_macro_text): Don't remap filenames within directives
>
> gcc/ChangeLog:
>
>      * doc/invoke.texi: Document prefix-maps don't affect directives

THanks.  Installed.  Sorry about the wait.

jeff



      reply	other threads:[~2022-11-18 20:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-02 10:47 Richard Purdie
2022-11-18 20:14 ` Jeff Law [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d9f6221-a088-35b7-8e3b-5fc1a86b5f07@gmail.com \
    --to=jeffreyalaw@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).