From: Jeff Law <jeffreyalaw@gmail.com>
To: Christophe Lyon <christophe.lyon@arm.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH v2] genmultilib: Add sanity check
Date: Fri, 18 Nov 2022 12:42:10 -0700 [thread overview]
Message-ID: <60cd8d77-8f33-bf5c-6316-f035f12c53d8@gmail.com> (raw)
In-Reply-To: <20221103095259.4095606-1-christophe.lyon@arm.com>
On 11/3/22 03:52, Christophe Lyon via Gcc-patches wrote:
> When a list of dirnames is provided to genmultilib, its length is
> expected to match the number of options. If this is not the case, the
> build fails later for reasons not obviously related to this mistake.
> This patch adds a sanity check to help diagnose such cases.
>
> Tested by adding an option to t-aarch64 and no corresponding dirname,
> with both bash and dash.
>
> v2: do not use arrays (bash feature).
>
> OK for trunk?
>
> gcc/ChangeLog:
>
> * genmultilib: Add sanity check.
OK. It should be interesting to see if it trips.
jeff
next prev parent reply other threads:[~2022-11-18 19:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 13:10 [PATCH] " Christophe Lyon
2022-11-02 17:29 ` Joseph Myers
2022-11-02 17:57 ` Christophe Lyon
2022-11-03 9:52 ` [PATCH v2] " Christophe Lyon
2022-11-18 19:42 ` Jeff Law [this message]
2022-11-21 10:16 ` Mark Wielaard
2022-11-21 12:12 ` Christophe Lyon
2022-11-21 12:32 ` Mark Wielaard
2022-11-21 12:35 ` Christophe Lyon
2022-11-21 23:01 ` Activate gcc builder problem emails (Was: [PATCH v2] genmultilib: Add sanity check) Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60cd8d77-8f33-bf5c-6316-f035f12c53d8@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=christophe.lyon@arm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).