From: HAO CHEN GUI <guihaoc@linux.ibm.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, David <dje.gcc@gmail.com>,
"Kewen.Lin" <linkw@linux.ibm.com>,
Peter Bergner <bergner@linux.ibm.com>
Subject: Re: [PATCH, rs6000] Correct return value of check_p9modulo_hw_available
Date: Fri, 5 Aug 2022 11:05:24 +0800 [thread overview]
Message-ID: <61eee51f-5910-db3d-e56f-7b0339da1d50@linux.ibm.com> (raw)
In-Reply-To: <20220804170941.GM25951@gate.crashing.org>
Hi Segher,
Thanks so much for your explanation. Now I have a clear picture about
the usage of return value. Patch was committed as r13-1971.
Thanks
Gui Haochen
On 5/8/2022 上午 1:09, Segher Boessenkool wrote:
> Hi!
>
> On Thu, Aug 04, 2022 at 05:55:20PM +0800, HAO CHEN GUI wrote:
>> This patch corrects return value of check_p9modulo_hw_available. It should
>> return 0 when p9modulo is supported.
>
> It would be harder to make such mistakes if it used exit() explicitly,
> so that the reader is reminded the shell semantics are used here instead
> of the C conventions.
>
>> - return (r == 2);
>> + return (r != 2);
>
> so that then would be smth like
>
> if (r == 2)
> exit (0);
> else
> exit (1);
>
> (which makes the exit code for failure explicit as well).
>
> Terse is good. Explicit is good as well :-)
>
> (You don't have to make this change here of course, but keep it in mind
> for the future :-) )
>
>
> Segher
prev parent reply other threads:[~2022-08-05 3:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 9:55 HAO CHEN GUI
2022-08-04 11:12 ` Kewen.Lin
2022-08-04 17:09 ` Segher Boessenkool
2022-08-05 3:05 ` HAO CHEN GUI [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61eee51f-5910-db3d-e56f-7b0339da1d50@linux.ibm.com \
--to=guihaoc@linux.ibm.com \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=linkw@linux.ibm.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).