From: "Kewen.Lin" <linkw@linux.ibm.com>
To: HAO CHEN GUI <guihaoc@linux.ibm.com>
Cc: Segher Boessenkool <segher@kernel.crashing.org>,
David <dje.gcc@gmail.com>, Peter Bergner <bergner@linux.ibm.com>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, rs6000] Correct return value of check_p9modulo_hw_available
Date: Thu, 4 Aug 2022 19:12:49 +0800 [thread overview]
Message-ID: <6498d130-7682-29cc-fe65-c89c5c6e4676@linux.ibm.com> (raw)
In-Reply-To: <315e43e5-3167-50de-08ec-ab83202e55a0@linux.ibm.com>
Hi Haochen,
on 2022/8/4 17:55, HAO CHEN GUI wrote:
> Hi,
> This patch corrects return value of check_p9modulo_hw_available. It should
> return 0 when p9modulo is supported.
Good catch! There is no case using p9modulo_hw for now, no coverage, sigh...
>
> Bootstrapped and tested on powerpc64-linux BE and LE with no regressions.
> Is this okay for trunk? Any recommendations? Thanks a lot.
This patch is OK, thanks!
BR,
Kewen
>
> ChangeLog
> 2022-08-04 Haochen Gui <guihaoc@linux.ibm.com>
>
> gcc/testsuite/
> * lib/target-supports.exp (check_p9modulo_hw_available): Correct return
> value.
>
>
> patch.diff
> diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
> index 4ed7b25b9a4..04a2a8e8659 100644
> --- a/gcc/testsuite/lib/target-supports.exp
> +++ b/gcc/testsuite/lib/target-supports.exp
> @@ -2288,7 +2288,7 @@ proc check_p9modulo_hw_available { } {
> {
> int i = 5, j = 3, r = -1;
> asm ("modsw %0,%1,%2" : "+r" (r) : "r" (i), "r" (j));
> - return (r == 2);
> + return (r != 2);
> }
> } $options
> }
next prev parent reply other threads:[~2022-08-04 11:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 9:55 HAO CHEN GUI
2022-08-04 11:12 ` Kewen.Lin [this message]
2022-08-04 17:09 ` Segher Boessenkool
2022-08-05 3:05 ` HAO CHEN GUI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6498d130-7682-29cc-fe65-c89c5c6e4676@linux.ibm.com \
--to=linkw@linux.ibm.com \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=guihaoc@linux.ibm.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).