From: Xi Ruoyao <xry111@xry111.site>
To: Fangrui Song <maskray@google.com>
Cc: Dimitrije Milosevic <Dimitrije.Milosevic@syrmia.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Djordje Todorovic <Djordje.Todorovic@syrmia.com>
Subject: Re: [PATCH] Mips: Enable asynchronous unwind tables with both ASAN and TSAN
Date: Tue, 05 Jul 2022 12:51:05 +0800 [thread overview]
Message-ID: <624d68f0ea3c05a90e384e7e06a6597ab4158b3a.camel@xry111.site> (raw)
In-Reply-To: <CAFP8O3LjYm+PJviSRkWpHySui8Qkyt9j4Y7uQwvXvY86OSRRaQ@mail.gmail.com>
On Mon, 2022-07-04 at 21:21 -0700, Fangrui Song wrote:
> Clang considers that asan/msan/tsan/dataflow/etc enables
> -fasynchronous-unwind-tables by default so I assume this GCC change is
> fine.
I agree it's fine, but the problem is TSAN is currently "unsupported"
within GCC (i. e. when you build gcc libtsan is not built). So it does
not make any benefit to commit this change before making TSAN supported
on GCC side.
Dimitrije told me TSAN should be supported on 64-bit MIPS, but I can't
make it work fine with GCC. I'll need some time to debug...
> With https://reviews.llvm.org/D102046 ("[sanitizer] Fall back to fast
> unwinder"), compiler-rt may fall back to the frame pointer based
> unwinder. There is not strong need to have the default
> -fasynchronous-unwind-tables or -funwind-tables behavior.
> However, most targets still default to omit frame pointer, so it's a
> bit unfortunately that we need to enable unwind tables to get good
> diagnostics.
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2022-07-05 4:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 14:18 [PATCH] Mips: Enable asynchronous unwind tables with both ASAN and LSAN Dimitrije Milosevic
[not found] ` <e598dc5e6fb56c31e8ce8ff4569bb3bc64b49dfa.camel@xry111.site>
2022-05-30 7:10 ` [PATCH] Mips: Enable asynchronous unwind tables with both ASAN and TSAN Dimitrije Milosevic
2022-06-07 8:20 ` Xi Ruoyao
2022-06-07 10:13 ` Dimitrije Milosevic
2022-06-11 12:03 ` Xi Ruoyao
2022-07-04 14:28 ` Dimitrije Milosevic
2022-07-05 1:54 ` Xi Ruoyao
2022-07-05 4:21 ` Fangrui Song
2022-07-05 4:51 ` Xi Ruoyao [this message]
2022-07-05 8:47 ` Xi Ruoyao
2022-07-05 9:13 ` Xi Ruoyao
2022-07-05 6:30 ` Dimitrije Milosevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=624d68f0ea3c05a90e384e7e06a6597ab4158b3a.camel@xry111.site \
--to=xry111@xry111.site \
--cc=Dimitrije.Milosevic@syrmia.com \
--cc=Djordje.Todorovic@syrmia.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=maskray@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).