From: Dimitrije Milosevic <Dimitrije.Milosevic@Syrmia.com>
To: Xi Ruoyao <xry111@xry111.site>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Djordje Todorovic <Djordje.Todorovic@syrmia.com>
Subject: Re: [PATCH] Mips: Enable asynchronous unwind tables with both ASAN and TSAN
Date: Mon, 4 Jul 2022 14:28:30 +0000 [thread overview]
Message-ID: <AM0PR03MB48828354AEFA34C729E2756282BE9@AM0PR03MB4882.eurprd03.prod.outlook.com> (raw)
In-Reply-To: <e6fe20bf45983b25d987dbc38cfc68c71b5181e8.camel@xry111.site>
On Saturday, June 11, 2022 2:03 PM, Xi wrote:
> Just tried TSAN_SUPPORTED=yes with asynchronous unwind tables enabled,
> but I got some strange test failures for tls_race.c:
>
> FAIL: c-c++-common/tsan/tls_race.c -O0 output pattern test
> Output was:
> ThreadSanitizer: CHECK failed: tsan_platform_linux.cpp:452 "((thr_end)) <= ((tls_addr + tls_size))" (0xffec35f8c0, 0xffec35f784) (tid=748216)
> #0 __tsan::CheckUnwind() ../../../../gcc/libsanitizer/tsan/tsan_rtl.cpp:627 (libtsan.so.2+0xa30ec)
> #1 __sanitizer::CheckFailed(char const*, int, char const*, unsigned long long, unsigned long long) ../../../../gcc/libsanitizer/sanitizer_common/sanitizer_termination.cpp:86 (libtsan.so.2+0xeb8cc)
> #2 __tsan::ImitateTlsWrite(__tsan::ThreadState*, unsigned long, unsigned long) ../../../../gcc/libsanitizer/tsan/tsan_platform_linux.cpp:452 (libtsan.so.2+0xa0cac)
> #3 __tsan::ThreadStart(__tsan::ThreadState*, unsigned int, unsigned long long, __sanitizer::ThreadType) ../../../../gcc/libsanitizer/tsan/tsan_rtl_thread.cpp:197 (libtsan.so.2+0xc0e88)
> #4 __tsan_thread_start_func ../../../../gcc/libsanitizer/tsan/tsan_interceptors_posix.cpp:1009 (libtsan.so.2+0x3e5dc)
> #5 start_thread /sources/glibc-2.35/nptl/pthread_create.c:442 (libc.so.6+0xc75f4)
>
> I've tried to diagnose the root cause but failed.
Hi Xi, thanks for looking into this. I've tried running the testsuite on a cross-toolchain (as I do not currently have access to a physical machine)
for a MIPS64R6 and the test passes successfully. Could you please verify that the test fails solely based on this change?
Kind regards,
Dimitrije
next prev parent reply other threads:[~2022-07-04 14:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 14:18 [PATCH] Mips: Enable asynchronous unwind tables with both ASAN and LSAN Dimitrije Milosevic
[not found] ` <e598dc5e6fb56c31e8ce8ff4569bb3bc64b49dfa.camel@xry111.site>
2022-05-30 7:10 ` [PATCH] Mips: Enable asynchronous unwind tables with both ASAN and TSAN Dimitrije Milosevic
2022-06-07 8:20 ` Xi Ruoyao
2022-06-07 10:13 ` Dimitrije Milosevic
2022-06-11 12:03 ` Xi Ruoyao
2022-07-04 14:28 ` Dimitrije Milosevic [this message]
2022-07-05 1:54 ` Xi Ruoyao
2022-07-05 4:21 ` Fangrui Song
2022-07-05 4:51 ` Xi Ruoyao
2022-07-05 8:47 ` Xi Ruoyao
2022-07-05 9:13 ` Xi Ruoyao
2022-07-05 6:30 ` Dimitrije Milosevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR03MB48828354AEFA34C729E2756282BE9@AM0PR03MB4882.eurprd03.prod.outlook.com \
--to=dimitrije.milosevic@syrmia.com \
--cc=Djordje.Todorovic@syrmia.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).