* [PATCH 1/6] Avoid shorten_binary_op on VECTOR_TYPE
@ 2023-06-23 8:26 Richard Biener
2023-06-23 14:50 ` Jeff Law
0 siblings, 1 reply; 2+ messages in thread
From: Richard Biener @ 2023-06-23 8:26 UTC (permalink / raw)
To: gcc-patches; +Cc: polacek
When we disallow TYPE_PRECISION on VECTOR_TYPEs it shows that
shorten_binary_op performs some checks on that that are likely
harmless in the end. The following bails out early for
VECTOR_TYPE operations to avoid those questionable checks.
Bootstrap and regtest ongoing on x86_64-unknown-linux-gnu.
OK?
gcc/c-family/
* c-common.cc (shorten_binary_op): Exit early for VECTOR_TYPE
operations.
---
gcc/c-family/c-common.cc | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/gcc/c-family/c-common.cc b/gcc/c-family/c-common.cc
index 9c8eed5442a..34566a342bd 100644
--- a/gcc/c-family/c-common.cc
+++ b/gcc/c-family/c-common.cc
@@ -1338,6 +1338,10 @@ shorten_binary_op (tree result_type, tree op0, tree op1, bool bitwise)
int uns;
tree type;
+ /* Do not shorten vector operations. */
+ if (VECTOR_TYPE_P (result_type))
+ return result_type;
+
/* Cast OP0 and OP1 to RESULT_TYPE. Doing so prevents
excessive narrowing when we call get_narrower below. For
example, suppose that OP0 is of unsigned int extended
--
2.35.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/6] Avoid shorten_binary_op on VECTOR_TYPE
2023-06-23 8:26 [PATCH 1/6] Avoid shorten_binary_op on VECTOR_TYPE Richard Biener
@ 2023-06-23 14:50 ` Jeff Law
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Law @ 2023-06-23 14:50 UTC (permalink / raw)
To: Richard Biener, gcc-patches; +Cc: polacek
On 6/23/23 02:26, Richard Biener via Gcc-patches wrote:
> When we disallow TYPE_PRECISION on VECTOR_TYPEs it shows that
> shorten_binary_op performs some checks on that that are likely
> harmless in the end. The following bails out early for
> VECTOR_TYPE operations to avoid those questionable checks.
>
> Bootstrap and regtest ongoing on x86_64-unknown-linux-gnu.
>
> OK?
>
> gcc/c-family/
> * c-common.cc (shorten_binary_op): Exit early for VECTOR_TYPE
> operations.
OK. Oh how I want shorten_binary_op to go away :(
jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-23 14:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-23 8:26 [PATCH 1/6] Avoid shorten_binary_op on VECTOR_TYPE Richard Biener
2023-06-23 14:50 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).