public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Biener <richard.guenther@gmail.com>
To: "Clément Chigot" <chigot@adacore.com>
Cc: gcc-patches@gcc.gnu.org, tom@tromey.com, pinskia@gmail.com
Subject: Re: [PATCH] configure: remove dependencies on gmp and mpfr when gdb is disabled
Date: Fri, 6 Jan 2023 10:01:54 +0100	[thread overview]
Message-ID: <64573A4D-6CD0-4D68-A762-6069871C01FE@gmail.com> (raw)
In-Reply-To: <CAJ307EifQ=CLNKUs9SaUuK0si8cLeChTcV4ouRLF3Wuh_VYrCA@mail.gmail.com>



> Am 06.01.2023 um 09:44 schrieb Clément Chigot via Gcc-patches <gcc-patches@gcc.gnu.org>:
> 
> On Fri, Jan 6, 2023 at 9:39 AM Clément Chigot <chigot@adacore.com> wrote:
>> 
>> Since 91e0d22025e0bf2af2e364cb7214a05512a0c431, the configure checks
>> about GMP and MPFR for gdb builds have been moved to the toplevel
>> configure.
>> However, it doesn't take into account the --disable-gdb option. Meaning
>> that a build without gdb will require these libraries even if not
>> needed.
>> 
>> ChangeLog:
>> 
>>        * configure.ac: Skip GMP and MPFR when --disable-gdb is
>>        provided.
>>        * configure: Regenerate.
>> ---
>> configure    | 4 +++-
>> configure.ac | 4 +++-
>> 2 files changed, 6 insertions(+), 2 deletions(-)
>> 
>> diff --git a/configure b/configure
>> index d6716e38e99..85883099410 100755
>> --- a/configure
>> +++ b/configure
>> @@ -7913,7 +7913,9 @@ if test -d ${srcdir}/gcc ; then
>>   require_mpc=yes
>> fi
>> if test -d ${srcdir}/gdb ; then
>> -  require_gmp=yes
>> +  if test "x$enable_gdb" != xno; then
>> +   require_gmp=yes
>> +  fi
>> fi
>> 
>> gmplibs="-lmpfr -lgmp"
>> diff --git a/configure.ac b/configure.ac
>> index 737c1a1172b..2b612dce6e9 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -1489,7 +1489,9 @@ if test -d ${srcdir}/gcc ; then
>>   require_mpc=yes
>> fi
>> if test -d ${srcdir}/gdb ; then
>> -  require_gmp=yes
>> +  if test "x$enable_gdb" != xno; then
>> +   require_gmp=yes
>> +  fi
>> fi
>> 
>> gmplibs="-lmpfr -lgmp"
>> --
>> 2.25.1
> 
> This patch has already been merged in the binutils repository see [1].

Ok for GCC 

Richard 

> [1] https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=5fb0e308577143ceb313fde5538dc9ecb038f29f
> 
> Thanks,
> Clément

      reply	other threads:[~2023-01-06  9:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-06  8:39 Clément Chigot
2023-01-06  8:43 ` Clément Chigot
2023-01-06  9:01   ` Richard Biener [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64573A4D-6CD0-4D68-A762-6069871C01FE@gmail.com \
    --to=richard.guenther@gmail.com \
    --cc=chigot@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=pinskia@gmail.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).