* [PATCH] c++: fix xobj diagnostic messages
@ 2024-01-16 21:28 Marek Polacek
2024-01-16 22:03 ` Jason Merrill
0 siblings, 1 reply; 2+ messages in thread
From: Marek Polacek @ 2024-01-16 21:28 UTC (permalink / raw)
To: GCC Patches, Jason Merrill
Tested x86_64-pc-linux-gnu, ok for trunk?
-- >8 --
Diagnostics should start with a lower-case letter.
gcc/cp/ChangeLog:
* decl.cc (grokdeclarator) <case cdk_function>: Tweak diagnostic
messages.
---
gcc/cp/decl.cc | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gcc/cp/decl.cc b/gcc/cp/decl.cc
index b10a72a87bf..b805addc328 100644
--- a/gcc/cp/decl.cc
+++ b/gcc/cp/decl.cc
@@ -13394,12 +13394,12 @@ grokdeclarator (const cp_declarator *declarator,
gcc_rich_location bad_xobj_parm
(DECL_SOURCE_LOCATION (TREE_VALUE (parm)));
error_at (&bad_xobj_parm,
- "Only the first parameter of a member function "
- "can be declared as an explicit object parameter");
+ "only the first parameter of a member function "
+ "can be declared as an explicit object parameter");
}
if (bad_xobj_parm_encountered && xobj_parm)
inform (DECL_SOURCE_LOCATION (xobj_parm),
- "Valid explicit object parameter declared here");
+ "valid explicit object parameter declared here");
}
if (reqs)
base-commit: 6a6f338c1cbfc2585cd85358a83e601fb959445e
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] c++: fix xobj diagnostic messages
2024-01-16 21:28 [PATCH] c++: fix xobj diagnostic messages Marek Polacek
@ 2024-01-16 22:03 ` Jason Merrill
0 siblings, 0 replies; 2+ messages in thread
From: Jason Merrill @ 2024-01-16 22:03 UTC (permalink / raw)
To: Marek Polacek, GCC Patches
On 1/16/24 16:28, Marek Polacek wrote:
> Tested x86_64-pc-linux-gnu, ok for trunk?
OK.
> -- >8 --
> Diagnostics should start with a lower-case letter.
>
> gcc/cp/ChangeLog:
>
> * decl.cc (grokdeclarator) <case cdk_function>: Tweak diagnostic
> messages.
> ---
> gcc/cp/decl.cc | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gcc/cp/decl.cc b/gcc/cp/decl.cc
> index b10a72a87bf..b805addc328 100644
> --- a/gcc/cp/decl.cc
> +++ b/gcc/cp/decl.cc
> @@ -13394,12 +13394,12 @@ grokdeclarator (const cp_declarator *declarator,
> gcc_rich_location bad_xobj_parm
> (DECL_SOURCE_LOCATION (TREE_VALUE (parm)));
> error_at (&bad_xobj_parm,
> - "Only the first parameter of a member function "
> - "can be declared as an explicit object parameter");
> + "only the first parameter of a member function "
> + "can be declared as an explicit object parameter");
> }
> if (bad_xobj_parm_encountered && xobj_parm)
> inform (DECL_SOURCE_LOCATION (xobj_parm),
> - "Valid explicit object parameter declared here");
> + "valid explicit object parameter declared here");
> }
>
> if (reqs)
>
> base-commit: 6a6f338c1cbfc2585cd85358a83e601fb959445e
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-16 22:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-16 21:28 [PATCH] c++: fix xobj diagnostic messages Marek Polacek
2024-01-16 22:03 ` Jason Merrill
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).