From: Jason Merrill <jason@redhat.com>
To: Marek Polacek <polacek@redhat.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] c++: ICE-on-invalid with designated initializer [PR106983]
Date: Thu, 22 Sep 2022 18:18:31 -0400 [thread overview]
Message-ID: <6914f74d-0c69-eb2b-36d8-f17a8340bb25@redhat.com> (raw)
In-Reply-To: <20220920210552.835987-1-polacek@redhat.com>
On 9/20/22 17:05, Marek Polacek wrote:
> We ICE in the code added in r12-7117: type_build_dtor_call gets
> the error_mark_node because the type of 'prev' wasn't declared.
>
> Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk?
OK.
> PR c++/106983
>
> gcc/cp/ChangeLog:
>
> * typeck2.cc (split_nonconstant_init_1): Check TYPE_P.
>
> gcc/testsuite/ChangeLog:
>
> * g++.dg/other/error36.C: New test.
> ---
> gcc/cp/typeck2.cc | 2 +-
> gcc/testsuite/g++.dg/other/error36.C | 13 +++++++++++++
> 2 files changed, 14 insertions(+), 1 deletion(-)
> create mode 100644 gcc/testsuite/g++.dg/other/error36.C
>
> diff --git a/gcc/cp/typeck2.cc b/gcc/cp/typeck2.cc
> index 688e9c15326..75fd0e2a9bf 100644
> --- a/gcc/cp/typeck2.cc
> +++ b/gcc/cp/typeck2.cc
> @@ -597,7 +597,7 @@ split_nonconstant_init_1 (tree dest, tree init, bool last,
> if (prev == field_index)
> break;
> tree ptype = TREE_TYPE (prev);
> - if (type_build_dtor_call (ptype))
> + if (TYPE_P (ptype) && type_build_dtor_call (ptype))
> {
> tree pcref = build3 (COMPONENT_REF, ptype, dest, prev,
> NULL_TREE);
> diff --git a/gcc/testsuite/g++.dg/other/error36.C b/gcc/testsuite/g++.dg/other/error36.C
> new file mode 100644
> index 00000000000..556287816fd
> --- /dev/null
> +++ b/gcc/testsuite/g++.dg/other/error36.C
> @@ -0,0 +1,13 @@
> +// PR c++/106983
> +// { dg-do compile { target c++20 } }
> +
> +typedef unsigned long long A;
> +typedef union
> +{
> + struct B s; // { dg-error "incomplete" }
> + A a;
> +} U;
> +void f (A x, unsigned int b)
> +{
> + const U y = {.a = x};
> +}
>
> base-commit: be60aa5b608b5f09fadfeff852a46589ac311a42
prev parent reply other threads:[~2022-09-22 22:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 21:05 Marek Polacek
2022-09-22 22:18 ` Jason Merrill [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6914f74d-0c69-eb2b-36d8-f17a8340bb25@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).