From: Joseph Myers <joseph@codesourcery.com>
To: Longjun Luo <luolongjuna@gmail.com>
Cc: <gcc-patches@gcc.gnu.org>, <sangyan@huawei.com>
Subject: Re: [PATCH] libcpp: suppress builtin macro redefined warnings for __LINE__
Date: Thu, 1 Dec 2022 21:10:44 +0000 [thread overview]
Message-ID: <6ac6c8e6-d18a-8aae-2ae3-ecdfed291755@codesourcery.com> (raw)
In-Reply-To: <ebcf63f3-143e-0af4-c0c2-4855188ad957@gmail.com>
On Fri, 2 Dec 2022, Longjun Luo via Gcc-patches wrote:
> They are ./gcc/testsuite/gcc.dg/cpp/warn-redefined.c and
> ./gcc/testsuite/gcc.dg/cpp/warn-redefined-2.c
>
> These two cases redefine the __TIME__ macro when using the option
> '-Wbuiltin-macro-redefined'.
>
> I think I shoud add a test to verify __LINE__ macro in these two cases.
I think it should be a test that doesn't use either
-Wbuiltin-macro-redefined or -Wno-builtin-macro-redefined - a test of how
the compiler behaves by default.
> So, the patch itself has no problem. What I need do is to rich its test cases
> and update change log, right?
The patch needs review, but I'm fine with the principle that
-Wno-builtin-macro-redefined should apply to __LINE__ as it does to
various other built-in macros.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2022-12-01 21:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 4:31 Longjun Luo
2022-12-01 17:01 ` Joseph Myers
2022-12-01 18:23 ` Longjun Luo
2022-12-01 19:07 ` Joseph Myers
2022-12-01 19:51 ` Longjun Luo
2022-12-01 21:10 ` Joseph Myers [this message]
2023-01-12 16:02 ` Longjun Luo
2023-04-30 18:30 ` Jeff Law
2023-04-30 23:14 ` Jeff Law
2023-04-30 23:19 ` Andrew Pinski
2023-01-12 16:05 ` Longjun Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ac6c8e6-d18a-8aae-2ae3-ecdfed291755@codesourcery.com \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=luolongjuna@gmail.com \
--cc=sangyan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).