From: Longjun Luo <luolongjuna@gmail.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org, sangyan@huawei.com
Subject: Re: [PATCH] libcpp: suppress builtin macro redefined warnings for __LINE__
Date: Fri, 2 Dec 2022 02:23:31 +0800 [thread overview]
Message-ID: <8767c6bc-5b37-ca10-1176-e341081c555f@gmail.com> (raw)
In-Reply-To: <ff97862b-2dd1-463e-c44a-8d46463038e8@codesourcery.com>
[-- Attachment #1: Type: text/plain, Size: 1590 bytes --]
On 12/2/2022 1:01 AM, Joseph Myers wrote:
> On Thu, 1 Dec 2022, Longjun Luo via Gcc-patches wrote:
>
>> diff --git a/gcc/testsuite/gcc.dg/builtin-redefine.c b/gcc/testsuite/gcc.dg/builtin-redefine.c
>> index 882b2210992..9d5b42252ee 100644
>> --- a/gcc/testsuite/gcc.dg/builtin-redefine.c
>> +++ b/gcc/testsuite/gcc.dg/builtin-redefine.c
>> @@ -71,7 +71,6 @@
>> /* { dg-bogus "Expected built-in is not defined" "" { target *-*-* } .-1 } */
>> #endif
>>
>> -#define __LINE__ 0 /* { dg-warning "-:\"__LINE__\" redef" } */
>> #define __INCLUDE_LEVEL__ 0 /* { dg-warning "-:\"__INCLUDE_LEVEL__\" redef" } */
>> #define __COUNTER__ 0 /* { dg-warning "-:\"__COUNTER__\" redef" } */
> Is there some existing test that verifies that this redefinition is still
> diagnosed by default (in the absence of -Wno-builtin-macro-redefined)?
I am not sure I have fully understood your meaning. The problem here is
that if I try to redefine __LINE__ macro in the situation that projects
use the option '-Werror', the compile will fail.
For example, the following compilation will fail:
/echo "void main(){}" | gcc -D__LINE__=0 -Werror -x c -/
The compilation output is:
<command-line>: error: "__LINE__" redefined [-Werror]
cc1: all warnings being treated as errors
As I know, most projects including Linux kernel enable '-Werror' by
default. So if I try to redefine __LINE__ macro in this situation, it
will be impossible.
The reason that I want to redefine __LINE__ macro has been explained in
the commit.
Thanks for your patience and hope I hit the point.
next prev parent reply other threads:[~2022-12-01 18:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 4:31 Longjun Luo
2022-12-01 17:01 ` Joseph Myers
2022-12-01 18:23 ` Longjun Luo [this message]
2022-12-01 19:07 ` Joseph Myers
2022-12-01 19:51 ` Longjun Luo
2022-12-01 21:10 ` Joseph Myers
2023-01-12 16:02 ` Longjun Luo
2023-04-30 18:30 ` Jeff Law
2023-04-30 23:14 ` Jeff Law
2023-04-30 23:19 ` Andrew Pinski
2023-01-12 16:05 ` Longjun Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8767c6bc-5b37-ca10-1176-e341081c555f@gmail.com \
--to=luolongjuna@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=sangyan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).