public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] config/rs6000/t-float128: Don't encode full build paths into headers
Date: Wed, 02 Nov 2022 10:45:46 +0000	[thread overview]
Message-ID: <6af4b473cfba6d3ea729dd8e3bbd8bd23fbb94ac.camel@linuxfoundation.org> (raw)
In-Reply-To: <20220817121014.1824521-1-richard.purdie@linuxfoundation.org>

On Wed, 2022-08-17 at 13:10 +0100, Richard Purdie via Gcc-patches
wrote:
> Avoid encoding full build paths into headers, just use the basename of the file.
> This aids build reproducibility where the build paths vary and source is saved
> for debugging purposes.
> 
> libgcc/ChangeLog:
> 
>     * config/rs6000/t-float128: Don't encode full build paths into headers
> 

I think this patch is at risk of being lost. It is a simple change
which aids reproducibility so I'm hoping someone might be able to help
with review/merging?

Thanks!

Richard


> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  libgcc/config/rs6000/t-float128 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libgcc/config/rs6000/t-float128 b/libgcc/config/rs6000/t-float128
> index b09b5664af0..513e63748f1 100644
> --- a/libgcc/config/rs6000/t-float128
> +++ b/libgcc/config/rs6000/t-float128
> @@ -103,7 +103,7 @@ $(ibm128_dec_objs)	: INTERNAL_CFLAGS += $(IBM128_CFLAGS_DECIMAL)
>  $(fp128_softfp_src) : $(srcdir)/soft-fp/$(subst -sw,,$(subst kf,tf,$@)) $(fp128_dep)
>  	@src="$(srcdir)/soft-fp/$(subst -sw,,$(subst kf,tf,$@))"; \
>  	echo "Create $@"; \
> -	(echo "/* file created from $$src */"; \
> +	(echo "/* file created from `basename $$src` */"; \
>  	 echo; \
>  	 sed -f $(fp128_sed) < $$src) > $@
>  




      reply	other threads:[~2022-11-02 10:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-17 12:10 Richard Purdie
2022-11-02 10:45 ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6af4b473cfba6d3ea729dd8e3bbd8bd23fbb94ac.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).