From: Joseph Myers <joseph@codesourcery.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] c-family: Support #pragma region/endregion [PR85487]
Date: Fri, 11 Nov 2022 00:01:32 +0000 [thread overview]
Message-ID: <6d96c99-db95-6f33-a0e-7c662ce05a78@codesourcery.com> (raw)
In-Reply-To: <20221110031345.193991-1-jwakely@redhat.com>
On Thu, 10 Nov 2022, Jonathan Wakely via Gcc-patches wrote:
> Something similar has been proposed before, but didn't get approval.
> Jeff wanted a more general framework for ignoring pragmas. It might make
> sense to do that, and reuse it for the Darwin-specific 'mark' pragmas.
> But as I said in the PR, I looked at the darwin ones and they are unique
> among all pragmas in GCC. I am not going there, sorry :-)
>
> In the PR it was suggested that we should check for syntax errors in
> these pragmas or make sure there are matching region/endregion pairs.
> I disagree. This is a simple, low-risk patch that removes unhelpful
> warnings for users who have these macros for their editor to process.
> It's not our business to check for correct use of these macros, their
> meaning is determined by other tools that we don't control. We should
> just not complain when we see them, and no more.
>
> Tested powerpc64le-linux. OK for trunk?
OK.
--
Joseph S. Myers
joseph@codesourcery.com
prev parent reply other threads:[~2022-11-11 0:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 3:13 Jonathan Wakely
2022-11-11 0:01 ` Joseph Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d96c99-db95-6f33-a0e-7c662ce05a78@codesourcery.com \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).