From: Jason Merrill <jason@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] c++: Fix up mangling ICE with void{} [PR106863]
Date: Thu, 20 Oct 2022 10:19:59 -0400 [thread overview]
Message-ID: <6e993e48-8fff-e62b-f86b-e7359c17e62a@redhat.com> (raw)
In-Reply-To: <Y0+upcPTOYp9/pFM@tucnak>
On 10/19/22 04:00, Jakub Jelinek wrote:
> Hi!
>
> We ICE on the following testcase during mangling, finish_compound_literal
> returns for void{} void_node and the mangler doesn't handle it.
> Handling void_node in the mangler seems problematic to me, because
> we don't know for which case it has been created.
> The following patch arranges to mangle just void{} the same as void()
> if that is what we want to use, by doing what we do for void() when
> processing void{}.
> The code does that only if processing_template_decl, because otherwise
> build_functional_cast will return void_node, so calling it looks like
> wasted effort to me. But if you want to call it unconditionally,
> I can certainly do that too.
I think in a template we want the same early-return behavior as in the
processing_template_decl block farther down in the function:
specifically, we want to return a CONSTRUCTOR (for which
COMPOUND_LITERAL_P is true), so it mangles as void{} rather than void().
> Or do you want to mangle it differently? How?
>
> clang++ doesn't support DR2351, so I can't check what they are doing.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux.
>
> 2022-10-19 Jakub Jelinek <jakub@redhat.com>
>
> PR c++/106863
> * semantics.cc (finish_compound_literal): For void{}, if
> processing_template_decl return build_functional_cast of NULL_TREE
> to VOID_TYPE rather than void_node.
>
> * g++.dg/cpp0x/dr2351-2.C: New test.
>
> --- gcc/cp/semantics.cc.jj 2022-10-10 09:31:57.410985121 +0200
> +++ gcc/cp/semantics.cc 2022-10-18 15:24:08.726026118 +0200
> @@ -3164,7 +3164,12 @@ finish_compound_literal (tree type, tree
> {
> /* DR2351 */
> if (VOID_TYPE_P (type) && CONSTRUCTOR_NELTS (compound_literal) == 0)
> - return void_node;
> + {
> + if (!processing_template_decl)
> + return void_node;
> + location_t loc = cp_expr_loc_or_input_loc (compound_literal);
> + return build_functional_cast (loc, type, NULL_TREE, complain);
> + }
> else if (VOID_TYPE_P (type)
> && processing_template_decl
> && maybe_zero_constructor_nelts (compound_literal))
> --- gcc/testsuite/g++.dg/cpp0x/dr2351-2.C.jj 2022-10-18 15:27:01.146690132 +0200
> +++ gcc/testsuite/g++.dg/cpp0x/dr2351-2.C 2022-10-18 15:27:39.909164970 +0200
> @@ -0,0 +1,16 @@
> +// DR2351
> +// { dg-do compile { target c++11 } }
> +
> +void bar (int);
> +
> +template <typename T>
> +auto foo (T t) -> decltype (bar (t), void{})
> +{
> + return bar (t);
> +}
> +
> +int
> +main ()
> +{
> + foo (0);
> +}
>
> Jakub
>
next prev parent reply other threads:[~2022-10-20 14:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 8:00 Jakub Jelinek
2022-10-20 14:19 ` Jason Merrill [this message]
2022-10-20 14:38 ` [PATCH] c++, v2: " Jakub Jelinek
2022-10-20 14:45 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e993e48-8fff-e62b-f86b-e7359c17e62a@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).