From: Sandra Loosemore <sandra@codesourcery.com>
To: <gcc-patches@gcc.gnu.org>
Cc: <jakub@redhat.com>, <tobias@codesourcery.com>,
Julian Brown <julian@codesourcery.com>
Subject: Re: [PATCH 3/3] OpenMP: Use enumerators for names of trait-sets and traits
Date: Tue, 21 Nov 2023 13:48:54 -0700 [thread overview]
Message-ID: <6eac92d0-ee67-2979-7ba3-abf08be2d2a7@codesourcery.com> (raw)
In-Reply-To: <20231119092151.1690294-4-sandra@codesourcery.com>
On 11/19/23 02:21, Sandra Loosemore wrote:
> This patch introduces enumerators to represent trait-set names and
> trait names, which makes it easier to use tables to control other
> behavior and for switch statements to dispatch on the tags. The tags
> are stored in the same place in the TREE_LIST structure (OMP_TSS_ID or
> OMP_TS_ID) and are encoded there as integer constants.
>
> This patch has only been lightly tested and still has at least one bug
> that causes an ICE. :-(
Update: I've tracked down the ICE to me having introduced an incorrect variable
initialization in omp_context_compute_score. I'm now looking at fixing
interfaces to avoid the separate bug in omp_mark_declare_variant that Julian
reported, and I'll post a revised part 3 in the next day or two.
-Sandra
next prev parent reply other threads:[~2023-11-21 20:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-19 9:21 [PATCH 0/3] OpenMP: Improve data abstractions for context selectors Sandra Loosemore
2023-11-19 9:21 ` [PATCH 1/3] OpenMP: Introduce accessor macros and constructors " Sandra Loosemore
2023-11-19 9:21 ` [PATCH 2/3] OpenMP: Unify representation of name-list properties Sandra Loosemore
2023-11-19 9:21 ` [PATCH 3/3] OpenMP: Use enumerators for names of trait-sets and traits Sandra Loosemore
2023-11-21 20:48 ` Sandra Loosemore [this message]
2023-11-20 10:32 ` [PATCH 0/3] OpenMP: Improve data abstractions for context selectors Julian Brown
2023-11-22 16:22 ` [PATCH V2 3/3] OpenMP: Use enumerators for names of trait-sets and traits Sandra Loosemore
2023-11-27 17:19 ` Tobias Burnus
2023-11-27 18:18 ` Tobias Burnus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6eac92d0-ee67-2979-7ba3-abf08be2d2a7@codesourcery.com \
--to=sandra@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=julian@codesourcery.com \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).