From: Ken Matsui <kmatsui@gcc.gnu.org>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: Ken Matsui <kmatsui@gcc.gnu.org>,
gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: Re: [PATCH 08/14] libstdc++: Optimize std::is_compound compilation performance
Date: Wed, 10 Jan 2024 19:02:51 -0800 [thread overview]
Message-ID: <6iya7iiwgudfkg7ivmcwbaoz7zykkcurxiyddpiwl2oscgbnaw@txni3qzp5gkt> (raw)
In-Reply-To: <CACb0b4nAF4BsSjmsaxLTkVQfj-mpwV1+Z4WFKCOs+8rMf90K9A@mail.gmail.com>
On 01-10 (21:21), Jonathan Wakely wrote:
> On Wed, 10 Jan 2024 at 19:41, Ken Matsui <kmatsui@gcc.gnu.org> wrote:
> >
> > This patch optimizes the compilation performance of std::is_compound
> > by dispatching to the new __is_arithmetic built-in trait.
>
> OK for trunk (no need to wait for anything else to be approved).
>
Thank you for your all reviews! This commit message is not quite accurate,
so I will update it before committing.
> >
> > libstdc++-v3/ChangeLog:
> >
> > * include/std/type_traits (is_compound): Do not use __not_.
> > (is_compound_v): Use is_fundamental_v instead.
> >
> > Signed-off-by: Ken Matsui <kmatsui@gcc.gnu.org>
> > ---
> > libstdc++-v3/include/std/type_traits | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits
> > index 1c560d97e85..6294f5af533 100644
> > --- a/libstdc++-v3/include/std/type_traits
> > +++ b/libstdc++-v3/include/std/type_traits
> > @@ -784,7 +784,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
> > /// is_compound
> > template<typename _Tp>
> > struct is_compound
> > - : public __not_<is_fundamental<_Tp>>::type { };
> > + : public __bool_constant<!is_fundamental<_Tp>::value> { };
> >
> > /// is_member_pointer
> > #if _GLIBCXX_USE_BUILTIN_TRAIT(__is_member_pointer)
> > @@ -3358,7 +3358,7 @@ template <typename _Tp>
> > template <typename _Tp>
> > inline constexpr bool is_scalar_v = is_scalar<_Tp>::value;
> > template <typename _Tp>
> > - inline constexpr bool is_compound_v = is_compound<_Tp>::value;
> > + inline constexpr bool is_compound_v = !is_fundamental_v<_Tp>;
> >
> > #if _GLIBCXX_USE_BUILTIN_TRAIT(__is_member_pointer)
> > template <typename _Tp>
> > --
> > 2.43.0
> >
>
next prev parent reply other threads:[~2024-01-11 3:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 9:22 [PATCH 00/14] Optimize integral-related type traits Ken Matsui
2024-01-10 9:22 ` [PATCH 01/14] c++: Implement __is_integral built-in trait Ken Matsui
2024-01-17 0:30 ` Jason Merrill
2024-01-17 7:42 ` Jonathan Wakely
2024-01-17 11:28 ` Joseph Myers
2024-01-10 9:22 ` [PATCH 02/14] libstdc++: Optimize std::is_integral compilation performance Ken Matsui
2024-01-10 21:19 ` Jonathan Wakely
2024-01-10 9:22 ` [PATCH 03/14] c++: Implement __is_floating_point built-in trait Ken Matsui
2024-01-17 0:36 ` Jason Merrill
2024-01-10 9:22 ` [PATCH 04/14] libstdc++: Optimize std::is_floating_point compilation performance Ken Matsui
2024-01-10 21:20 ` Jonathan Wakely
2024-01-10 9:22 ` [PATCH 05/14] c++: Implement __is_arithmetic built-in trait Ken Matsui
2024-01-10 9:22 ` [PATCH 06/14] libstdc++: Optimize std::is_arithmetic compilation performance Ken Matsui
2024-01-10 21:20 ` Jonathan Wakely
2024-01-10 9:22 ` [PATCH 07/14] libstdc++: Optimize std::is_fundamental " Ken Matsui
2024-01-10 9:22 ` [PATCH 08/14] libstdc++: Optimize std::is_compound " Ken Matsui
2024-01-10 21:21 ` Jonathan Wakely
2024-01-11 3:02 ` Ken Matsui [this message]
2024-01-11 4:14 ` [committed] " Ken Matsui
2024-01-10 9:23 ` [PATCH 09/14] c++: Implement __is_unsigned built-in trait Ken Matsui
2024-01-17 0:41 ` Jason Merrill
2024-01-10 9:23 ` [PATCH 10/14] libstdc++: Optimize std::is_unsigned compilation performance Ken Matsui
2024-01-10 21:22 ` Jonathan Wakely
2024-01-10 9:23 ` [PATCH 11/14] c++: Implement __is_signed built-in trait Ken Matsui
2024-01-10 9:23 ` [PATCH 12/14] libstdc++: Optimize std::is_signed compilation performance Ken Matsui
2024-01-10 21:22 ` Jonathan Wakely
2024-01-10 9:23 ` [PATCH 13/14] c++: Implement __is_scalar built-in trait Ken Matsui
2024-01-10 19:59 ` Ken Matsui
2024-01-10 9:23 ` [PATCH 14/14] libstdc++: Optimize std::is_scalar compilation performance Ken Matsui
2024-01-10 21:22 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6iya7iiwgudfkg7ivmcwbaoz7zykkcurxiyddpiwl2oscgbnaw@txni3qzp5gkt \
--to=kmatsui@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).