From: Jason Merrill <jason@redhat.com>
To: Jonathan Wakely <jwakely.gcc@gmail.com>
Cc: libstdc++@gcc.gnu.org, Ken Matsui <kmatsui@gcc.gnu.org>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 01/14] c++: Implement __is_integral built-in trait
Date: Tue, 16 Jan 2024 19:30:46 -0500 [thread overview]
Message-ID: <25fff4d0-f560-4cb9-9180-6ec6620dfaa4@redhat.com> (raw)
In-Reply-To: <20240110194031.2384005-2-kmatsui@gcc.gnu.org>
On 1/10/24 04:22, Ken Matsui wrote:
> +/* Return true if T is an integral type. With __STRICT_ANSI__, __int128 and
> + unsigned __int128 are not integral types. */
This really needs a rationale, since they are actually integer types. I
know __int128 is considered an extension rather than an extended integer
type under the standard, but is there a writeup we can point to for why?
And even if we don't want to subject it to all the standard requirements
of an extended integer type, why not still say it's an integral type?
flag_iso is only supposed to disable features that could conflict with
obscure but standard-conforming code, and since __int128 is in the
reserved namespace, I'd think it should be safe to support (to the
degree that we do) regardless of flag_iso.
Jason
next prev parent reply other threads:[~2024-01-17 0:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 9:22 [PATCH 00/14] Optimize integral-related type traits Ken Matsui
2024-01-10 9:22 ` [PATCH 01/14] c++: Implement __is_integral built-in trait Ken Matsui
2024-01-17 0:30 ` Jason Merrill [this message]
2024-01-17 7:42 ` Jonathan Wakely
2024-01-17 11:28 ` Joseph Myers
2024-01-10 9:22 ` [PATCH 02/14] libstdc++: Optimize std::is_integral compilation performance Ken Matsui
2024-01-10 21:19 ` Jonathan Wakely
2024-01-10 9:22 ` [PATCH 03/14] c++: Implement __is_floating_point built-in trait Ken Matsui
2024-01-17 0:36 ` Jason Merrill
2024-01-10 9:22 ` [PATCH 04/14] libstdc++: Optimize std::is_floating_point compilation performance Ken Matsui
2024-01-10 21:20 ` Jonathan Wakely
2024-01-10 9:22 ` [PATCH 05/14] c++: Implement __is_arithmetic built-in trait Ken Matsui
2024-01-10 9:22 ` [PATCH 06/14] libstdc++: Optimize std::is_arithmetic compilation performance Ken Matsui
2024-01-10 21:20 ` Jonathan Wakely
2024-01-10 9:22 ` [PATCH 07/14] libstdc++: Optimize std::is_fundamental " Ken Matsui
2024-01-10 9:22 ` [PATCH 08/14] libstdc++: Optimize std::is_compound " Ken Matsui
2024-01-10 21:21 ` Jonathan Wakely
2024-01-11 3:02 ` Ken Matsui
2024-01-11 4:14 ` [committed] " Ken Matsui
2024-01-10 9:23 ` [PATCH 09/14] c++: Implement __is_unsigned built-in trait Ken Matsui
2024-01-17 0:41 ` Jason Merrill
2024-01-10 9:23 ` [PATCH 10/14] libstdc++: Optimize std::is_unsigned compilation performance Ken Matsui
2024-01-10 21:22 ` Jonathan Wakely
2024-01-10 9:23 ` [PATCH 11/14] c++: Implement __is_signed built-in trait Ken Matsui
2024-01-10 9:23 ` [PATCH 12/14] libstdc++: Optimize std::is_signed compilation performance Ken Matsui
2024-01-10 21:22 ` Jonathan Wakely
2024-01-10 9:23 ` [PATCH 13/14] c++: Implement __is_scalar built-in trait Ken Matsui
2024-01-10 19:59 ` Ken Matsui
2024-01-10 9:23 ` [PATCH 14/14] libstdc++: Optimize std::is_scalar compilation performance Ken Matsui
2024-01-10 21:22 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25fff4d0-f560-4cb9-9180-6ec6620dfaa4@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely.gcc@gmail.com \
--cc=kmatsui@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).