From: Nathan Sidwell <nathan@acm.org>
To: Patrick Palka <ppalka@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Jason Merrill <jason@redhat.com>
Subject: Re: [PATCH] c++: modules ICE with typename friend declaration
Date: Sat, 17 Sep 2022 02:17:25 -0400 [thread overview]
Message-ID: <7098923e-36f1-7c29-1d3b-941c09a45ab1@acm.org> (raw)
In-Reply-To: <ac9fd65f-de1c-e8fa-48d7-a6e3e837ac9a@idea>
On 9/16/22 11:54, Patrick Palka wrote:
> On Fri, 16 Sep 2022, Nathan Sidwell wrote:
>
>> Thanks, this looks right. Sigh templates can mess up ones mental invariants!
>> The test case should really be a foo_[ab].C kind, to test both sides of the streaming. Bonus points for using the template after importing. And you need the dg-module-cmi annotation to check /and then
>> delete/ the gcm file produced.
>
> Aha, thanks very much for the pointers, I redid the testcase using
> lang-3_[abc].C as an example. How does the following look?
>
yes, that's right, thanks!
nathan
--
Nathan Sidwell
prev parent reply other threads:[~2022-09-17 6:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 20:16 Patrick Palka
2022-09-16 7:45 ` Nathan Sidwell
2022-09-16 15:54 ` Patrick Palka
2022-09-16 18:39 ` Bernhard Reutner-Fischer
2022-09-17 6:17 ` Nathan Sidwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7098923e-36f1-7c29-1d3b-941c09a45ab1@acm.org \
--to=nathan@acm.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=ppalka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).