From: Jeff Law <jeffreyalaw@gmail.com>
To: Andrew Pinski <apinski@marvell.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] MATCH: Fix zero_one_valued_p not to match signed 1 bit integers
Date: Fri, 9 Jun 2023 15:44:28 -0600 [thread overview]
Message-ID: <76443f30-50c3-d144-0379-2fc81d1ee342@gmail.com> (raw)
In-Reply-To: <20230609172753.3164342-1-apinski@marvell.com>
On 6/9/23 11:27, Andrew Pinski via Gcc-patches wrote:
> So for the attached testcase, we assumed that zero_one_valued_p would
> be the value [0,1] but currently zero_one_valued_p matches also
> signed 1 bit integers.
> This changes that not to match that and fixes the 2 new testcases at
> all optimization levels.
>
> OK for GCC 13? Bootstrapped and tested on x86_64-linux-gnu with no regressions.
>
> PR tree-optimization/110165
> PR tree-optimization/110166
>
> gcc/ChangeLog:
>
> * match.pd (zero_one_valued_p): Don't accept
> signed 1-bit integers.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.c-torture/execute/pr110165-1.c: New test.
> * gcc.c-torture/execute/pr110166-1.c: New test.
OK.
Jeff
next prev parent reply other threads:[~2023-06-09 21:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 17:27 Andrew Pinski
2023-06-09 21:44 ` Jeff Law [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-06-09 1:47 Andrew Pinski
2023-06-09 9:06 ` Richard Biener
2023-06-09 9:11 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76443f30-50c3-d144-0379-2fc81d1ee342@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=apinski@marvell.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).