From: Jeff Law <jeffreyalaw@gmail.com>
To: Dimitar Dimitrov <dimitar@dinux.eu>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] testsuite: Add filter for target socket support
Date: Sun, 20 Nov 2022 09:20:59 -0700 [thread overview]
Message-ID: <77fa8b8d-9528-2e4e-6681-e67907bf6b37@gmail.com> (raw)
In-Reply-To: <20221120100257.281467-1-dimitar@dinux.eu>
On 11/20/22 03:02, Dimitar Dimitrov wrote:
> The new analyzer tests for sockets are failing on embedded targets.
> The newlib and avr-libc C libraries do not support sockets.
>
> At first I considered a coarse filtering on the existing
> effective_target_freestanding check. But seeing how lib/target-supports.exp
> is slowly turning into a copy of autotools, I kept the tradition and added
> a new fine grained "socket" filter.
>
> I also considered adding effective_target_posix, but could not
> figure out a reliable C code to perform the check.
>
> Testing done:
> - No changes in gcc.sum for x86_64-pc-linux-gnu, with or without this
> patch.
> - Filtered cases are now UNSUPPORTED instead of failing on AVR and PRU
> backends.
>
> Ok for trunk?
>
> gcc/ChangeLog:
>
> * doc/sourcebuild.texi (sockets): Document new check.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.dg/analyzer/fd-accept.c: Require sockets.
> * gcc.dg/analyzer/fd-bind.c: Ditto.
> * gcc.dg/analyzer/fd-connect.c: Ditto.
> * gcc.dg/analyzer/fd-datagram-socket.c: Ditto.
> * gcc.dg/analyzer/fd-glibc-byte-stream-connection-server.c:
> Ditto.
> * gcc.dg/analyzer/fd-glibc-byte-stream-socket.c: Ditto.
> * gcc.dg/analyzer/fd-glibc-datagram-client.c: Ditto.
> * gcc.dg/analyzer/fd-glibc-datagram-socket.c: Ditto.
> * gcc.dg/analyzer/fd-listen.c: Ditto.
> * gcc.dg/analyzer/fd-manpage-getaddrinfo-client.c: Ditto.
> * gcc.dg/analyzer/fd-mappage-getaddrinfo-server.c: Ditto.
> * gcc.dg/analyzer/fd-meaning.c: Ditto.
> * gcc.dg/analyzer/fd-socket-meaning.c: Ditto.
> * gcc.dg/analyzer/fd-socket-misuse.c: Ditto.
> * gcc.dg/analyzer/fd-stream-socket-active-open.c: Ditto.
> * gcc.dg/analyzer/fd-stream-socket-passive-open.c: Ditto.
> * gcc.dg/analyzer/fd-stream-socket.c: Ditto.
> * gcc.dg/analyzer/fd-symbolic-socket.c: Ditto.
> * lib/target-supports.exp (check_effective_target_sockets): New
> check.
OK
jeff
prev parent reply other threads:[~2022-11-20 16:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-20 10:02 Dimitar Dimitrov
2022-11-20 16:20 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77fa8b8d-9528-2e4e-6681-e67907bf6b37@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=dimitar@dinux.eu \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).