Re: [PATCH] Libvtv-test: Fix the problem that scansarif.exp cannot be found in libvtv regression test.

[WANG Xuerui <i@xen0n.name>]

On 2022/9/27 11:16, Lulu Cheng wrote:
> 	r13-967 add ARRIF output format. However libvtv does not add support.

"SARIF support was added in r13-967 but libvtv wasn't updated."

(Tip: always remember that English, unlike Chinese, isn't a 
"topic-prominent" language, meaning you should almost never put the 
"topic" at subject position of the sentence. IOW, if you find your 
English to be a perfect 1:1 mapping to some Chinese sentence, which is 
the case here, it's highly likely you need to improve it somehow. This 
is by no means personal, but the same pattern of broken English has been 
appearing in your and your teammates' commits since forever, so I'm 
afraid I have to point out.)

>
> 	commit 6cf276ddf22066af780335cd0072d2c27aabe468
> 	Author: David Malcolm <dmalcolm@redhat.com>
> 	Date:   Thu Jun 2 15:40:22 2022 -0400
>
> 	    diagnostics: add SARIF output format

And I don't think this reference is necessary, r13-967 is already a 
precise description.

>
> libvtv/ChangeLog:
>
> 	* testsuite/lib/libvtv-dg.exp: Add load_gcc_lib of scansarif.exp.
"Load scansarif.exp." -- another example of redundant expression (no pun 
intended on "expression").
> ---
>   libvtv/testsuite/lib/libvtv-dg.exp | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/libvtv/testsuite/lib/libvtv-dg.exp b/libvtv/testsuite/lib/libvtv-dg.exp
> index b140c194cdc..454d916e556 100644
> --- a/libvtv/testsuite/lib/libvtv-dg.exp
> +++ b/libvtv/testsuite/lib/libvtv-dg.exp
> @@ -12,6 +12,8 @@
>   # along with this program; if not, write to the Free Software
>   # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
>   
> +load_gcc_lib scansarif.exp
> +
>   proc libvtv-dg-test { prog do_what extra_tool_flags } {
>       return [gcc-dg-test-1 libvtv_target_compile $prog $do_what $extra_tool_flags]
>   }
Otherwise LGTM.