Re: Fix typo in 'libgomp.c/target-51.c' (was: [patch] OpenMP: Set default-device-var with OMP_TARGET_OFFLOAD=mandatory)

[Tobias Burnus <tobias@codesourcery.com>]

On 14.06.23 10:09, Thomas Schwinge wrote:
> This reminds me of the (unresolved)https://gcc.gnu.org/PR81886
> "Means to determine at runtime foffload targets specified at compile time".

I think there is the problem that we also support offloading in
libraries. Thus, if you compile the main program without offloading and
then link in a shared offloading-providing library (possibly with
dlopen), it comes (too) late. Thus, we either exclude devices which
could be later used – or we have to live with providing devices
(existing in hardware and with libgomp support) for which no executable
code is available.

As long as the number of devices is not a dynamic property, I guess we
can only handle one or the other.

> I intend to push the attached "Fix typo in 'libgomp.c/target-51.c'"
> after testing.
> Let me know if I should also adjust the new 'target { ! offload_device }'
> diagnostic "[...] MANDATORY but only the host device is available" to
> include a comma before 'but', for consistency with the other existing
> diagnostics (cited above)?

I think it makes sense to be consistent. Thus: Yes, please add the commas.

Thanks,

Tobias

-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955