From: Joseph Myers <josmyers@redhat.com>
To: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Cc: gcc@gcc.gnu.org, ubizjak@gmail.com, hubicka@ucw.cz,
hjl.tools@gmail.com, gcc-patches@gcc.gnu.org
Subject: Re: [Patch, stage-1, RFC]: i386: attribute regparm/stdcall and vaargs
Date: Fri, 2 Feb 2024 12:28:42 +0000 (UTC) [thread overview]
Message-ID: <79d178f-1b83-3dfc-7515-ccb1996de379@redhat.com> (raw)
In-Reply-To: <20240202115331.37b4a158@nbbrfq.loc>
On Fri, 2 Feb 2024, Bernhard Reutner-Fischer via Gcc wrote:
> Hi Joseph!
>
> On Tue, 30 Jan 2024 14:54:49 +0000 (UTC)
> Joseph Myers <josmyers@redhat.com> wrote:
>
> > On Tue, 30 Jan 2024, Bernhard Reutner-Fischer via Gcc wrote:
> >
> > > * builtin-attrs.def (ATTR_TM_NOTHROW_RT_LIST): Use ATTR_NOTHROW_LIST
> > > instead of ATTR_TM_NOTHROW_LIST, thus removing ATTR_TM_REGPARM.
> >
> > That doesn't make sense. ATTR_TM_NOTHROW_RT_LIST is specifically a
> > transactional memory attribute list, but you're removing all transactional
> > memory attributes from it. A list without the "*tm regparm" internal
> > attribute would have a different name.
> >
>
> AFAICS there is no pre-existing attr list with just returns_twice and
> nothrow. Would ATTR_NOTHROW_RT_LIST be more appropriate as name, and
> should i move this up to before the format attribute lists, before
> DEF_FORMAT_ATTRIBUTE?
Yes, both of those seem appropriate for such an attribute list.
I do not know what attributes are appropriate for _ITM_beginTransaction.
--
Joseph S. Myers
josmyers@redhat.com
prev parent reply other threads:[~2024-02-02 12:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 23:14 Bernhard Reutner-Fischer
2024-01-30 14:54 ` Joseph Myers
2024-02-02 10:53 ` Bernhard Reutner-Fischer
2024-02-02 12:28 ` Joseph Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79d178f-1b83-3dfc-7515-ccb1996de379@redhat.com \
--to=josmyers@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=hubicka@ucw.cz \
--cc=rep.dot.nop@gmail.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).