From: Xi Ruoyao <xry111@xry111.site>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>,
Dimitrije Milosevic <Dimitrije.Milosevic@Syrmia.com>
Cc: Djordje Todorovic <Djordje.Todorovic@syrmia.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Mips: Fix the ASAN shadow offset hook for the n32 ABI
Date: Wed, 03 Aug 2022 09:17:16 +0800 [thread overview]
Message-ID: <7a042cad563f7e302c79db07068c1a2949a4e5c1.camel@xry111.site> (raw)
In-Reply-To: <alpine.DEB.2.21.2207301417590.58390@angie.orcam.me.uk>
On Sat, 2022-07-30 at 14:22 +0100, Maciej W. Rozycki wrote:
> On Mon, 6 Jun 2022, Dimitrije Milosevic wrote:
>
> > * config/mips/mips.cc (mips_asan_shadow_offset): Reformat
> > to handle the N32 ABI.
>
> That's not what the change does.
>
> > * config/mips/mips.h (SUBTARGET_SHADOW_OFFSET): Remove
> > the macro, as it is not needed anymore.
>
> Why is the macro not needed anymore?
Because it's only used by mips_asan_shadow_offset and now we directly
code its content into mips_asan_shadow_offset.
SUBTARGET_SHADOW_OFFSET is only needed if a different subtarget (say,
mips64el-freebsd) needs a different shadow offset. But for MIPS we
don't have any subtarget other than mips*-linux-gnu* supporting ASAN so
we can omit SUBTARGET_SHADOW_OFFSET and fold the content directly into
the asan_shadow_offset target hook. RISCV port does the same.
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
prev parent reply other threads:[~2022-08-03 1:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 9:28 Dimitrije Milosevic
2022-06-07 8:17 ` Xi Ruoyao
2022-06-07 10:12 ` Dimitrije Milosevic
2022-07-30 13:22 ` Maciej W. Rozycki
2022-08-03 1:17 ` Xi Ruoyao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a042cad563f7e302c79db07068c1a2949a4e5c1.camel@xry111.site \
--to=xry111@xry111.site \
--cc=Dimitrije.Milosevic@Syrmia.com \
--cc=Djordje.Todorovic@syrmia.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=macro@orcam.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).