From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Dimitrije Milosevic <Dimitrije.Milosevic@Syrmia.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Djordje Todorovic <Djordje.Todorovic@syrmia.com>
Subject: Re: [PATCH] Mips: Fix the ASAN shadow offset hook for the n32 ABI
Date: Sat, 30 Jul 2022 14:22:55 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.21.2207301417590.58390@angie.orcam.me.uk> (raw)
In-Reply-To: <AM0PR03MB48829B2382BE4B8860AE317282A29@AM0PR03MB4882.eurprd03.prod.outlook.com>
On Mon, 6 Jun 2022, Dimitrije Milosevic wrote:
> * config/mips/mips.cc (mips_asan_shadow_offset): Reformat
> to handle the N32 ABI.
That's not what the change does.
> * config/mips/mips.h (SUBTARGET_SHADOW_OFFSET): Remove
> the macro, as it is not needed anymore.
Why is the macro not needed anymore?
I can see the change has already been committed, but no proper review was
done and I can hardly see how anyone can know why this change is correct.
If someone looks at it say in 10 years' time they can only try to guess.
Maciej
next prev parent reply other threads:[~2022-07-30 13:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 9:28 Dimitrije Milosevic
2022-06-07 8:17 ` Xi Ruoyao
2022-06-07 10:12 ` Dimitrije Milosevic
2022-07-30 13:22 ` Maciej W. Rozycki [this message]
2022-08-03 1:17 ` Xi Ruoyao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2207301417590.58390@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=Dimitrije.Milosevic@Syrmia.com \
--cc=Djordje.Todorovic@syrmia.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).